Bug 225903
Summary: | Merge Review: iproute | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> | ||||
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | mmaslano, redhat-bugzilla, rvokal | ||||
Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-10-24 10:54:40 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Nobody's working on this, feel free to take it
2007-01-31 19:05:36 UTC
rpmlint output on SRPM and RPM W: iproute invalid-license GPL The value of the License tag was not recognized. Known values are: "Affero GPL", "AFL", "ASL 1.0", "ASL 1.0+", "ASL 1.1", "ASL 1.1+", "ASL 2.0", "ASL 2.0+", "APSL 2.0", "APSL 2.0+", "Artistic 2.0", "Artistic clarified", "BitTorrent", "Boost", "BSD", "BSD with advertising", "CeCILL", "CDDL", "CPL", "Condor", "Copyright only", "Cryptix", "Crystal Stacker", "EPL", "eCos", "EFL 2.0", "EFL 2.0+", "EU Datagrid", "Giftware", "Glide", "GPL+", "GPL+ or Artistic", "GPLv2", "GPLv2 with exceptions", "GPLv2+", "GPLv3", "GPLv3+", "IBM", "IJG", "iMatix", "Intel ACPI", "Interbase", "ISC", "Jabber", "JasPer", "LGPLv2", "LGPLv2 with exceptions", "LGPLv2+", "LGPLv3", "LGPLv3+", "libtiff", "LPL", "LPPL", "mecab-ipadic", "MIT", "MPLv1.0", "MPLv1.0+", "MPLv1.1", "MPLv1.1+", "NCSA", "NGPL", "NOSL", "Netscape", "Nokia", "OpenLDAP", "OSL 1.0", "OSL 1.0+", "OSL 2.0", "OSL 2.0+", "OSL 3.0", "OSL 3.0+", "OpenSSL", "Phorum", "PHP", "Public Domain", "Python", "QPL", "RPSL", "Ruby", "Sleepycat", "SISSL", "SPL", "TCL", "UCD", "Vim", "VNLSL", "VSL", "W3C", "WTFPL", "wxWindows", "xinetd", "Zend", "ZPLv1.0", "ZPLv1.0+", "ZPLv2.0", "ZPLv2.0+", "zlib", "CDL", "FBSDDL", "GFDL", "Open Publication", "CC-BY", "CC- BY-SA", "DSL", "Free Art", "Arphic", "Bitstream Vera", "mplus", "OFL", "Utopia", "Redistributable, no modification permitted", "Freely redistributable without restriction". W: iproute unversioned-explicit-obsoletes shapecfg The specfile contains an unversioned Obsoletes: token, which will match all older, equal and newer versions of the obsoleted thing. This may cause update problems, restrict future package/provides naming, and may match something it was originally not inteded to match -- make the Obsoletes versioned if possible. W: iproute mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 44) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. I: iproute checking W: iproute file-not-utf8 /usr/share/man/man8/ss.8.gz The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). W: iproute obsolete-not-provided shapecfg If a package is obsoleted by a compatible replacement, the obsoleted package must also be provided in order to provide clean upgrade paths and not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the provides. E: iproute only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. correct above and update SPEC in CVS for further review. W: iproute unversioned-explicit-obsoletes shapecfg I think obsoletes is only warning. E: iproute only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. Movin (In reply to comment #2) > W: iproute unversioned-explicit-obsoletes shapecfg > I think obsoletes is only warning. > > E: iproute only-non-binary-in-usr-lib > There are only non binary files in /usr/lib so they should be in /usr/share. > Movin ??? what is that? Hello, once again, the last message from rpmlint is: E: iproute nly-non-binary-in-usr-lib but I can't fix it without upstream. I ask them about it. But are other things got updated in SPEC file? Yes, the spec file was updatet therefore no other problems than this one (#4) is occuring. thanks 1)any reason to use (pre) with BuildRequires? 2)Use macro usage. It is not consistent. check more at http://fedoraproject.org/wiki/Packaging/RPMMacros Created attachment 193321 [details]
update SPEC
You may like to test attached SPEC as it may solve rpmlint error.
Just a suggestion.
Can you check functionality of your package it this solves problem?
I made the final changes in spec file. I added smp flags and use macros. #9 I don't want do these changes. It's upstream thing. (In reply to comment #10) > I made the final changes in spec file. I added smp flags and use macros. > > #9 I don't want do these changes. It's upstream thing. And why you would like to see non binary files being installed in /usr/lib. I checked F-7 version and saw that in that version we have q_netem.so file and its valid to have that being installed in /usr/lib. But now I saw its no longer part of new devel version, thus no use to have other files installed at location /usr/lib/tc ping? q_netem.so isn't used any more but option netem is supported. The distribution in usr/lib is used by this function. Ok, I'll fix the paths (/usr/lib), have you see any other problems with review? I don't think so. So I need final updates to finish this review. The path is fixed in the latest build iproute-2.6.22-4.fc9 In build.log I saw following message warning: File listed twice: /sbin/cbq Remove following line from %files /sbin/cbq Fixed, any other issues? I don't want rebuild it again and again. (In reply to comment #18) > Fixed, any other issues? I don't want rebuild it again and again. thanks. No issues. That's why I have started asking maintainers of packages from other Merge-reviews to submit updates to some other website and that prevents maintainers building again and again for small issues. oops sorry but what you fixed for comment #18? I didn't see any change in SPEC for issue reported in comment #17 Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 20ef2767896a0f156b6fbabd47936f79 iproute2-2.6.22-070710.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. - duplicates in %files present as can be seen in build.log warning: File listed twice: /sbin/cbq ==> This can be solved at next build time of this package + file permissions are appropriate. + no scriptlets are used. + Package iproute-2.6.22-4.fc8 -> Provides: config(iproute) = 2.6.22-4.fc8 Requires: /bin/bash config(iproute) = 2.6.22-4.fc8 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.2.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libc.so.6(GLIBC_2.7) libdb-4.6.so libdl.so.2 libdl.so.2(GLIBC_2.0) libdl.so.2(GLIBC_2.1) libm.so.6 libm.so.6(GLIBC_2.0) libpthread.so.0 libpthread.so.0(GLIBC_2.0) libresolv.so.2 rtld(GNU_HASH) + Not a GUI app. APPROVED. |