Bug 2259268

Summary: Review Request: golang-github-distribution-reference - Go library to handle references to container images
Product: [Fedora] Fedora Reporter: Arthur Bols <arthur>
Component: Package ReviewAssignee: Fabio Alessandro Locati <me>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: me, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: me: fedora-review+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-03-10 17:50:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2259269    

Description Arthur Bols 2024-01-19 21:05:09 UTC
Spec URL: https://principis.fedorapeople.org/golang-github-distribution-reference.spec
SRPM URL: https://principis.fedorapeople.org/golang-github-distribution-reference-0.5.0-1.fc39.src.rpm
Description: Go library for handling references to container images held in container
registries.
Fedora Account System Username: principis

Comment 1 Fedora Review Service 2024-01-19 21:10:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6923234
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259268-golang-github-distribution-reference/fedora-rawhide-x86_64/06923234-golang-github-distribution-reference/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Alessandro Locati 2024-02-25 14:54:14 UTC
go2rpm package, fedora-review is correct:

- The specfile is sane.
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei.
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID)

Thanks!

Comment 3 Fedora Admin user for bugzilla script actions 2024-03-10 17:30:28 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-distribution-reference

Comment 4 Arthur Bols 2024-03-10 17:45:16 UTC
Thank you for the review!

Comment 5 Fedora Update System 2024-03-10 17:45:51 UTC
FEDORA-2024-8f51cf23c4 (golang-github-distribution-reference-0.5.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-8f51cf23c4

Comment 6 Fedora Update System 2024-03-10 17:50:19 UTC
FEDORA-2024-8f51cf23c4 (golang-github-distribution-reference-0.5.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.