Bug 2259530
| Summary: | python-lmdb fails to build with Python 3.13: implicit declaration of function ‘PyObject_AsReadBuffer’ | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karolina Surma <ksurma> |
| Component: | python-lmdb | Assignee: | Jakub Ruzicka <jakub.ruzicka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 41 | CC: | awilliam, epel-packagers-sig, fti-bugs, fzatlouk, jakub.ruzicka, jonathan, ksurma, mhroncok, pspacek, python-packagers-sig, zbyszek |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | AcceptedFreezeException | ||
| Fixed In Version: | python-lmdb-1.4.1-2.fc42 python-lmdb-1.4.1-2.fc41 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-09-13 04:32:04 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2260875, 2260877, 2244836, 2247866, 2291985, 2291987 | ||
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle. Changing version to 40. *** Bug 2291762 has been marked as a duplicate of this bug. *** This one looks difficult...at least for a non-C-expert like me. see https://github.com/jnwatson/py-lmdb/issues/362 . Hello, Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/ This package fails to install and maintainers are advised to take one of the following actions: - Fix this bug and close this bugzilla once the update makes it to the repository. (The same script that posted this comment will eventually close this bugzilla when the fixed package reaches the repository, so you don't have to worry about it.) or - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet. or - Orphan the package if you no longer plan to maintain it. If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue. This package may be orphaned in 7+ weeks. This is the first reminder (step 3) from the policy. Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug. I'm not interested in maintaining this package anymore - reassigning. (In reply to Petr Špaček from comment #5) > I'm not interested in maintaining this package anymore - reassigning. You were marked as the Bugzilla contact for this package. I reset this to the main admin @jruzicka. No point in reassigning this bugzilla to python-sig.org, please don't do that. Hello, Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/ This package fails to install and maintainers are advised to take one of the following actions: - Fix this bug and close this bugzilla once the update makes it to the repository. (The same script that posted this comment will eventually close this bugzilla when the fixed package reaches the repository, so you don't have to worry about it.) or - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet. or - Orphan the package if you no longer plan to maintain it. If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue. This package may be orphaned in 7+ weeks. This is the first reminder (step 3) from the policy. Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug. Hello, Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/ This package fails to install and maintainers are advised to take one of the following actions: - Fix this bug and close this bugzilla once the update makes it to the repository. (The same script that posted this comment will eventually close this bugzilla when the fixed package reaches the repository, so you don't have to worry about it.) or - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet. or - Orphan the package if you no longer plan to maintain it. If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue. This package may be orphaned in 4+ weeks. This is the second reminder (step 4) from the policy. Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug. This will require upstream fix as discussed in https://github.com/jnwatson/py-lmdb/issues/362 I'll make a new release once new upstream release (or at least merged fix) is available. This package has failed to build with Python 3.13 so far. Fedora 41 is already in the Beta Freeze phase. What's your plan going forward? Will the package be fixed in time for the Final Freeze of Fedora 41 (planned on Oct 15th 2024)? If you don't plan or can't fix the package before Fedora 41 goes into the Final Freeze phase, please retire the package. You can unretire it anytime during the Fedora 41 lifecycle - doing this now will simply ensure that we don't release Fedora with a broken package. Thank you! There isn't much Jakub can do about this. I've looked at the issue so I know. It requires *significant* change upstream to fix this without leaking. It's not something we can appropriately do on our own initiative downstream. We could theoretically do it and contribute it upstream, but it involves significant surgery to the fundamental design of the relevant code flow upstream, which the maintainer is more likely to want to do themselves than take as a contribution. And it's more engineering than we can realistically expect a packager to do (and more than I'm capable of in a reasonable timeframe). See the discussion at https://github.com/jnwatson/py-lmdb/issues/362#issuecomment-2168711185 . We...*could* use my incorrect patch that leaks buffers, I guess. I don't actually know how awful the practical impact of that is. I took a look at the code and came up with https://github.com/jnwatson/py-lmdb/issues/362#issuecomment-2329560855 Actually... https://github.com/jnwatson/py-lmdb/pull/368 Thanks a lot, that looks good to me. I'd be in favor of going ahead with that. Also proposing as an FE for F41 Beta so we can get it fixed there. Discussed during the 2024-09-09 blocker review meeting: [1] The decision to classify this bug as a AcceptedFreezeException (Beta) was made: "Once again, accepted as a fails-to-install issue, which we typically accept to avoid upgrade issues." [1] https://meetbot.fedoraproject.org/blocker-review_matrix_fedoraproject-org/2024-09-09/f41-blocker-review.2024-09-09-16.01.log.html FEDORA-2024-a075d56589 (python-lmdb-1.4.1-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a075d56589 FEDORA-2024-a075d56589 (python-lmdb-1.4.1-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-a809260e4b (python-lmdb-1.4.1-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-a809260e4b FEDORA-2024-0681840c5c (python-lmdb-1.4.1-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0681840c5c FEDORA-2024-edd7b14708 (python-lmdb-1.4.1-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-edd7b14708 FEDORA-2024-edd7b14708 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-edd7b14708` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-edd7b14708 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-edd7b14708 (python-lmdb-1.4.1-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |
python-lmdb fails to build with Python 3.13.0a3. lmdb/cpython.c: In function ‘val_from_buffer’: lmdb/cpython.c:586:12: error: implicit declaration of function ‘PyObject_AsReadBuffer’; did you mean ‘PyObject_GetBuffer’? [-Wimplicit-function-declaration] 586 | return PyObject_AsReadBuffer(buf, | ^~~~~~~~~~~~~~~~~~~~~ | PyObject_GetBuffer https://docs.python.org/3.13/whatsnew/3.13.html For the build logs, see: https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06933794-python-lmdb/ For all our attempts to build python-lmdb with Python 3.13, see: https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-lmdb/ Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.13: https://copr.fedorainfracloud.org/coprs/g/python/python3.13/ Let us know here if you have any questions. Python 3.13 is planned to be included in Fedora 41. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13. A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon. We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.