Bug 2259556

Dunno what happened here, the build just seemed to stop halfway through:
https://koji.fedoraproject.org/koji/taskinfo?taskID=111963353

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I../.. -I/builddir/build/BUILD/M2-release-1.22/M2/BUILD/x86_64-redhat-linux-gnu/../../include -I/builddir/build/BUILD/M2-release-1.22/M2/BUILD/x86_64-redhat-linux-gnu/include -I/builddir/build/BUILD/M2-release-1.22/M2/BUILD/x86_64-redhat-linux-gnu/usr-host/include -isystem /usr/include/libxml2 -I/usr/include/cddlib -I/usr/include/frobby -DNDEBUG -I/usr/include/cddlib -I/usr/include/eigen3 -I/usr/include -DBOOST_STACKTRACE_LINK -O2 -Wall -DNDEBUG -UDEBUG -I/usr/include/flexiblas/ -D__FFLASFFPACK_HAVE_CBLAS=1 -fopenmp -pthread -O2 -std=gnu++14 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fsigned-char -g -Wno-mismatched-tags -w -MT diophantine-solver.lo -MD -MP -MF .deps/diophantine-solver.Tpo -c diophantine-solver.C -o diophantine-solver.o
In file included from ../../linbox/matrix/sparse-matrix.h:76,
                 from ../../linbox/blackbox/lambda-sparse.h:29,
                 from ../../linbox/algorithms/rational-solver.h:44,
                 from ../../linbox/algorithms/diophantine-solver.h:29,
                 from diophantine-solver.C:26:
../../linbox/matrix/sparsematrix/sparse-ell-matrix.h: In member function 'LinBox::SparseMatrix<_Field, LinBox::SparseMatrixFormat::ELL>::_IndexedIterator<index_iterator, element_iterator, Field>& LinBox::SparseMatrix<_Field, LinBox::SparseMatrixFormat::ELL>::_IndexedIterator<index_iterator, element_iterator, Field>::operator=(const LinBox::SparseMatrix<_Field, LinBox::SparseMatrixFormat::ELL>::_IndexedIterator<index_iterator, element_iterator, Field>&)':
../../linbox/matrix/sparsematrix/sparse-ell-matrix.h:1216:44: error: assignment of read-only location '((LinBox::SparseMatrix<_Field, LinBox::SparseMatrixFormat::ELL>::_IndexedIterator<index_iterator, element_iterator, Field>*)this)->LinBox::SparseMatrix<_Field, LinBox::SparseMatrixFormat::ELL>::_IndexedIterator<index_iterator, element_iterator, Field>::_ld'
 1216 |                                 _ld        = iter._ld ;
      |                                 ~~~~~~~~~~~^~~~~~~~~~ 

I fixed a problem like this in linbox by adding a patch 0001-const_cast-missing.patch in https://src.fedoraproject.org/rpms/linbox/c/7389d46e81dc00dcb952b2ccbbbec3fb4fcc6c8b?branch=rawhide. I tried to fix the above problem in the bundled linbox here by concatenating that patch to the existing linbox-1.7.0.patch, and that applied without complaint, but the build still failed in the same way:

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -I../.. -I/builddir/build/BUILD
/M2-release-1.22/M2/BUILD/x86_64-redhat-linux-gnu/../../include -I/builddir/build/
BUILD/M2-release-1.22/M2/BUILD/x86_64-redhat-linux-gnu/include -I/builddir/build/B
UILD/M2-release-1.22/M2/BUILD/x86_64-redhat-linux-gnu/usr-host/include -isystem /u
sr/include/libxml2 -I/usr/include/cddlib -I/usr/include/frobby -DNDEBUG -I/usr/inc
lude/cddlib -I/usr/include/eigen3 -I/usr/include -DBOOST_STACKTRACE_LINK -O2 -Wall
 -DNDEBUG -UDEBUG -I/usr/include/flexiblas/ -D__FFLASFFPACK_HAVE_CBLAS=1 -fopenmp 
-pthread -O2 -std=gnu++14 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werro
r=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTI
ONS -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchrono
us-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer 
-mno-omit-leaf-frame-pointer -fsigned-char -g -Wno-mismatched-tags -w -MT diophant
ine-solver.lo -MD -MP -MF .deps/diophantine-solver.Tpo -c diophantine-solver.C -o 
diophantine-solver.o
In file included from ../../linbox/matrix/sparse-matrix.h:76,
                 from ../../linbox/blackbox/lambda-sparse.h:29,
                 from ../../linbox/algorithms/rational-solver.h:44,
                 from ../../linbox/algorithms/diophantine-solver.h:29,
                 from diophantine-solver.C:26:
../../linbox/matrix/sparsematrix/sparse-ell-matrix.h: In member function 'LinBox::SparseMatrix<_Field, LinBox::SparseMatrixFormat::ELL>::_IndexedIterator<index_iterator, element_iterator, Field>& LinBox::SparseMatrix<_Field, LinBox::SparseMatrixFormat::ELL>::_IndexedIterator<index_iterator, element_iterator, Field>::operator=(const LinBox::SparseMatrix<_Field, LinBox::SparseMatrixFormat::ELL>::_IndexedIterator<index_iterator, element_iterator, Field>&)':
../../linbox/matrix/sparsematrix/sparse-ell-matrix.h:1216:44: error: assignment of read-only location '((LinBox::SparseMatrix<_Field, LinBox::SparseMatrixFormat::ELL>::_IndexedIterator<index_iterator, element_iterator, Field>*)this)->LinBox::SparseMatrix<_Field, LinBox::SparseMatrixFormat::ELL>::_IndexedIterator<index_iterator, element_iterator, Field>::_ld'
 1216 |                                 _ld        = iter._ld ;
      |                                 ~~~~~~~~~~~^~~~~~~~~~

I’m sure there is something I’ve simply overlooked here, but I haven’t found it yet. I’m not planning to keep working on this at the moment.

Those const_casts seem like quite the code smell ... is there some underlying const-correctness bug that they're papering over?

(In reply to Jonathan Wakely from comment #3)
> Those const_casts seem like quite the code smell ... is there some
> underlying const-correctness bug that they're papering over?

The patch does look a little suspicious that way, and you may be right. I’m pretty sure I won’t have a chance to dig into their design, though.

Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 4+ weeks.
This is the second reminder (step 4) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

I updated linbox-1.7.0.patch to match the current linbox package and built this package as part of the SCIP/SoPlex effort.  The build succeeded.  The const issues referred to above are part of the linbox codebase, rather than Macaulay2.  I don't know what they are trying to do there.