Bug 225959

Summary:	Merge Review: kcc
Product:	[Fedora] Fedora	Reporter:	Nobody's working on this, feel free to take it <nobody>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eng-i18n-bugs, tagoh
Target Milestone:	---	Flags:	panemade: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-09-25 10:16:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nobody's working on this, feel free to take it 2007-01-31 19:14:34 UTC

Fedora Merge Review: kcc

http://cvs.fedora.redhat.com/viewcvs/devel/kcc/
Initial Owner: tagoh

Comment 1 Parag AN(पराग) 2007-09-20 11:32:41 UTC

rpmlint complained only
kcc.i386: W: no-url-tag
The URL tag is missing.

SHOULD:
  Preserve timestamp using install or cp commands.
  Though not mandatory can use disttag.

otherwise looks ok to me.

Comment 2 Akira TAGOH 2007-09-21 06:42:42 UTC

Thanks for reviewing. well, unfortunately this package is one of things that we
lost upstream. I don't think I can provide URL tag for this package. and I
intentionally didn't give a dist tag for this package because the application
itself is stable enough and the updates doesn't appears frequently. so I just
wanted to avoid appearing the dist tag doesn't match to the actual release.

Anyway, the below should fixes the timestamp issue:

Spec file: http://tagoh.fedorapeople.org/kcc/kcc.spec
SRPM file: http://tagoh.fedorapeople.org/kcc/kcc-2.3-27.src.rpm

Comment 3 Parag AN(पराग) 2007-09-21 10:02:44 UTC

change %defattr(-,root,root)
to 
%defattr(-,root,root,-)
else looks fine to me.

Comment 4 Akira TAGOH 2007-09-25 02:51:42 UTC

Thanks. improved.

Comment 5 Parag AN(पराग) 2007-09-25 08:25:43 UTC

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPM.
+ source files match upstream.
e8f4244fd5e7ffef51bcdca1c5a54ebc  kcc.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
- dist tag is NOT present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Pacakge kcc-2.3-27 ->
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) rtld(GNU_HASH)
+ Not a GUI app.

APPROVED.

Comment 6 Akira TAGOH 2007-09-25 10:16:43 UTC

Thanks. the updated kcc has been built on koji.