Bug 2259675

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6940667
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2259675-rust-sled/fedora-rawhide-x86_64/06940667-rust-sled/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

There are a few unsatisfiable optional dependencies:

Failed to resolve the transaction:
Problem 1: conflicting requests
  - nothing provides (crate(rio/default) >= 0.9.4 with crate(rio/default) < 0.10.0~) needed by rust-sled+rio-devel-0.34.7-1.fc40.noarch
 Problem 2: conflicting requests
  - nothing provides (crate(zstd/default) >= 0.9.0 with crate(zstd/default) < 0.10.0~) needed by rust-sled+zstd-devel-0.34.7-1.fc40.noarch
 Problem 3: package rust-sled+compression-devel-0.34.7-1.fc40.noarch requires crate(sled/zstd) = 0.34.7, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(zstd/default) >= 0.9.0 with crate(zstd/default) < 0.10.0~) needed by rust-sled+zstd-devel-0.34.7-1.fc40.noarch
 Problem 4: package rust-sled+io_uring-devel-0.34.7-1.fc40.noarch requires crate(sled/rio) = 0.34.7, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(rio/default) >= 0.9.4 with crate(rio/default) < 0.10.0~) needed by rust-sled+rio-devel-0.34.7-1.fc40.noarch
 Problem 5: package rust-sled+testing-devel-0.34.7-1.fc40.noarch requires crate(sled/compression) = 0.34.7, but none of the providers can be installed
  - package rust-sled+compression-devel-0.34.7-1.fc40.noarch requires crate(sled/zstd) = 0.34.7, but none of the providers can be installed
  - conflicting requests
  - nothing provides (crate(zstd/default) >= 0.9.0 with crate(zstd/default) < 0.10.0~) needed by rust-sled+zstd-devel-0.34.7-1.fc40.noarch

Looks like these would be used for io_uring and / or zstd compression support. Do you need these non-default / optional features?

If you don't need them, they could bet disabled (patched out / hidden from the package). If you *do* need them, the "rio" crate would need to be packaged, and the dependency on the "zstd" crate would need to be updated to a version that is available in Fedora.

Hmm besides that there seems to be still some issues, let me check those

Problem 1: nothing provides requested (crate(rand_distr/default) >= 0.3.0 with crate(rand_distr/default) < 0.4.0~)
 Problem 2: nothing provides requested (crate(zerocopy/default) >= 0.3.0 with crate(zerocopy/default) < 0.4.0~)

I'll remove this as well, as they're just dev dependencies.

I tried to review this today, but the package no longer compiles. Looks like something that was previously just a warning is now a hard error:

error: unnecessary qualification
   --> src/config.rs:276:15
    |
276 |         <T as std::convert::TryFrom<usize>>::Error: Debug,
    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: the lint level is defined here
   --> src/lib.rs:95:5
    |
95  |     unused_qualifications
    |     ^^^^^^^^^^^^^^^^^^^^^
help: remove the unnecessary path segments
    |
276 -         <T as std::convert::TryFrom<usize>>::Error: Debug,
276 +         <T as TryFrom<usize>>::Error: Debug,
    |

The error from the previous comment was due to compiler flag changes that have been reverted.

Now it looks like the issues pointed out in Comment 2 and 3 are still present.

I need this too and put up an updated version in https://bugzilla.redhat.com/show_bug.cgi?id=2284641

*** This bug has been marked as a duplicate of bug 2284641 ***