Bug 225983
| Summary: | Merge Review: less | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Ivana Varekova <varekova> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ed, redhat-bugzilla, varekova |
| Target Milestone: | --- | Flags: | ed:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-20 07:55:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 19:18:16 UTC
For build, rpmlint, etc. info please see: http://linux.dell.com/files/fedora/FixBuildRequires/mock-results-core/i386/less-394-6.fc7.src.rpm/result/ good: + source matches upstream + license is correct needswork or nits: - please remove the trailing '.' from the summary - rpmlint reports a few permissions errors: http://linux.dell.com/files/fedora/FixBuildRequires/mock-results-core/i386/less-394-6.fc7.src.rpm/result/rpmlint.log - please consider adding %{?dist} to the Release - please include the license in %doc since upstream includes it - please use the preferred BuildRoot - please use %defattr(-,root,root,-) All problems except of permission problem - which is reported by rpmlint are fixed in less-394-7.fc7. It is a problem to change permissions in cvs so the best solution I see is to leave them as they are. /etc/profile.d/less.{sh,csh} is 755, but should be 644:
E: less executable-sourced-script /etc/profile.d/less.sh 0755
E: less world-writable /usr/share/doc/less-394/LICENSE 0666
E: less executable-sourced-script /etc/profile.d/less.csh 0755
Thanks for your comment.
/etc/profile.d/less.{sh,csh} has the right permissions - rpmlint should not
display it as an error, the only problem was /usr/share/doc/less-394/LICENSE
permissions which are fixed in less-394-8.fc7.
Why would executable bits for /etc/profile.d/*sh scripts be correct? They do not have a shebang, so they cannot be executed alone, and /etc/bashrc and /etc/csh.cshrc check for them using -r (readability, not executability), then source (not execute) them. Some 5+ years ago it was necessary to have them executable because of bugs in the setup package, but that has been fixed since around Red Hat Linux 7.1, see bug 35714. 644 should be the correct permissions for them these days. Having them with incorrect permissions in CVS is an orthogonal issue which shouldn't prevent them from being shipped with correct permissions in the actual package. Thanks. You are right permmissions are changed in less-394-9.fc7. Ed, could you please look at less-394-9.fc7 and approved this review request or if you see any reason why you wdon't want to aproved it here. Thanks My apologies for taking so long to get back to this! All issues are fixed in less-394-9.fc7. APPROVED. |