Bug 2259847
| Summary: | RBD Mirror daemon count is not validated in StorageCluster | ||
|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat OpenShift Data Foundation | Reporter: | umanga <uchapaga> |
| Component: | ocs-operator | Assignee: | umanga <uchapaga> |
| Status: | CLOSED ERRATA | QA Contact: | Sidhant Agrawal <sagrawal> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.15 | CC: | muagarwa, nigoyal, odf-bz-bot, sagrawal, tnielsen |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | ODF 4.16.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 4.16.0-113 | Doc Type: | No Doc Update |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-17 13:12:29 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
umanga
2024-01-23 10:53:53 UTC
Not a 4.15 blocker The fix for the BZ has already been shipped with 4.15 but somehow the BZ was not updated properly. Missed the comment from Sidhant about this being a Failed QA one, reopening and keeping it in assigned. ``` CephRBDMirror.ceph.rook.io "ocs-storagecluster-cephrbdmirror" is invalid: spec.count: Invalid value: 0: spec.count in body should be greater than or equal to 1' ``` tnielsen Do you know why CephRBDMirror spec.count does not allow "0" value. I was expecting it to allow "0" which would scale down the rbd-mirror daemon. If it is by design, we need to remove this option in ocs-operator where we are trying to scale down rbd-mirror by setting count to "0". (In reply to umanga from comment #17) > ``` > CephRBDMirror.ceph.rook.io "ocs-storagecluster-cephrbdmirror" is invalid: > spec.count: Invalid value: 0: spec.count in body should be greater than or > equal to 1' > ``` > > tnielsen Do you know why CephRBDMirror spec.count does not allow > "0" value. I was expecting it to allow "0" which would scale down the > rbd-mirror daemon. > If it is by design, we need to remove this option in ocs-operator where we > are trying to scale down rbd-mirror by setting count to "0". RBD Mirroring would be disabled if there were 0 daemons running, so I believe it's just an assumption that we always expect at least one daemon to be created. I don't know of a strict reason to prevent that if it's helpful to have for scaling down the rbd mirror daemon temporarily, but I didn't look deeply. If RBD mirroring should be disabled then we expect the mirroring CR to be deleted. What is the need to keep the mirroring enabled even while all RBD mirror daemons are scaled down? (In reply to Travis Nielsen from comment #18) > > RBD Mirroring would be disabled if there were 0 daemons running, so I > believe it's just an assumption that we always expect at least one daemon to > be created. I don't know of a strict reason to prevent that if it's helpful > to have for scaling down the rbd mirror daemon temporarily, but I didn't > look deeply. If RBD mirroring should be disabled then we expect the > mirroring CR to be deleted. What is the need to keep the mirroring enabled > even while all RBD mirror daemons are scaled down? > Makes sense that we delete RBDMirror CR to disable RBD mirroring. However, in our case, we do not want to disable mirroring. We just need to restart the RBD mirror daemon. I assumed that setting the count to 0 would achieve that but did not verify if it works. So, I added a DaemonCount spec in StorageCluster and allow setting it to 0. And, that fails due to rook validation. Is it reasonable to support this in rook? When count is set to 0, just scale down the deployment but do not disable mirroring completely. It is up to the user to bring it back to 1. As a workaround, today we find the rbd-mirror deployment object and set it's replica to 0 but we'd like to avoid that. In worst case, we'll just need to drop this spec from 4.16 and look for our options in 4.17. If the goal is to restart the rbd mirror daemon, how about just delete the rbd mirror pod(s)? Then you don't need to change CR state temporarily and then revert it. (In reply to Travis Nielsen from comment #20) > If the goal is to restart the rbd mirror daemon, how about just delete the > rbd mirror pod(s)? Then you don't need to change CR state temporarily and > then revert it. This could be a problem when there are multiple users trying to restart the daemon. If everyone keeps deleting it without any checks, other users will be impacted. While we find a solution for this, I'll update the validation to match Rook validations to maintain consistency. We don't use this feature yet, so there is no impact with this change. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.16.0 security, enhancement & bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2024:4591 |