Bug 226021

Summary: Merge Review: libgpg-error
Product: [Fedora] Fedora Reporter: Nobody's working on this, feel free to take it <nobody>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED RAWHIDE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: nalin
Target Milestone: ---Flags: bugs.michael: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 1.6-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-12-07 15:47:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Nobody's working on this, feel free to take it 2007-01-31 19:23:52 UTC
Fedora Merge Review: libgpg-error

http://cvs.fedora.redhat.com/viewcvs/devel/libgpg-error/
Initial Owner: nalin@redhat.com

Comment 1 Michael Schwendt 2007-12-07 09:45:35 UTC
* Version 1.6 is available.


$ rpmlint  /home/qa/tmp/rpm/RPMS/libgpg-error-1.5-6.i386.rpm
libgpg-error.i386: W: file-not-utf8 /usr/share/doc/libgpg-error-1.5/ChangeLog
libgpg-error.i386: W: summary-not-capitalized libgpg-error


> Summary: libgpg-error

Summary: Library for error values used by GnuPG components


> Prereq: /sbin/ldconfig

Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig


> %makeinstall

Prefer "make DESTDIR=${RPM_BUILD_ROOT} install".


> %doc COPYING COPYING.LIB AUTHORS README INSTALL NEWS ChangeLog

The INSTALL file is irrelevant to RPM package users. It's common
practise not to include it.


> checking for msgfmt... no
> checking for gmsgfmt... :
> checking for xgettext... no
> checking for msgmerge... no

"BuildRequires: gettext" as a safety measure.


* You could enable the tests-suite:

%check
make check


* All minor issues. Hence:

APPROVED


Comment 2 Nalin Dahyabhai 2007-12-07 15:47:12 UTC
Following all suggestions.  Thanks for the review!