Bug 226033
| Summary: | Merge Review: libmng | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gwync, nmurray |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-04-15 13:54:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 19:25:50 UTC
rpmlint on SRPM:
libmng.src: E: non-utf8-spec-file /tmp/libmng-1.0.9-7.src.rpm.15198/libmng.spec
The character encoding of the spec file is not UTF-8. Convert it for example
using iconv(1).
libmng.src:41: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.
libmng.src: E: tag-not-utf8 %changelog
The character encoding of the value of this tag is not UTF-8.
rpmlint on RPMS:
libmng.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
libmng.i386: E: tag-not-utf8 %changelog
The character encoding of the value of this tag is not UTF-8.
libmng-debuginfo.i386: E: tag-not-utf8 %changelog
The character encoding of the value of this tag is not UTF-8.
libmng-devel.i386: E: tag-not-utf8 %changelog
The character encoding of the value of this tag is not UTF-8.
All pretty trivial, but should be fixed.
Source0 should change to:
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
md5sum of provided source and that from upstream differ:
[limb@fawkes SPECS]$ md5sum libmng-1.0.7.tar.gz
863002cf13a60ccfd8be641b62e3cc58 libmng-1.0.7.tar.gz
[limb@fawkes SPECS]$ md5sum ../SOURCES/libmng-1.0.9.tar.gz
ff1205ef70855a75c098ea09690413c6 ../SOURCES/libmng-1.0.9.tar.gz
- MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} ( or $RPM_BUILD_ROOT ). See Prepping BuildRoot For %install for details.
Fix.
Mock build OK, so BuildRequires are fine. No other blockers after full review, so fix the above and we're set.
Ping? Ping again? Reassigning to Spot since I'm taking ownership of orphan. Looking at rawhide, here are the remaining issues: libmng.src:40: W: configure-without-libdir-spec I think this one is safe to ignore, because it is triggering off the "[ ! -x ./configure ]", not the %configure on line 41. libmng.x86_64: W: no-documentation Definitely needs to be fixed. The UTF-8 issues were fixed (ancient changelog entry now has proper UTF-8). Source0 should be: http://download.sourceforge.net/sourceforge/%{name}/%{name}-%{version}.tar.gz Sha1sums match now (78ad516a1de79d00de720bf2a7c9afea2c896b09). - MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} ( or $RPM_BUILD_ROOT ). See Prepping BuildRoot For %install for details. Fixed in rawhide. Two more things I noticed:
(1) The devel subpackage has:
Requires: %{name} = %{version}
That should be:
Requires: %{name} = %{version}-%{release}
(2) The spec is using %makeinstall, instead of make DESTDIR=$RPM_BUILD_ROOT install. The latter works fine, so there is no good excuse not to use it.
With those two minor fixes committed to rawhide, I can close out this merge review.
Fixed and built in rawhide (f12). Looks good. APPROVED. Thanks! |