Bug 2260650

Summary: Review Request: pyznap - ZFS snapshot tool written in python
Product: [Fedora] Fedora Reporter: Arthur Bols <arthur>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2025-04-09 18:21:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .spec file difference from Copr build 6967306 to 7136245 none

Description Arthur Bols 2024-01-27 18:24:51 UTC
Spec URL: https://principis.fedorapeople.org/pyznap.spec
SRPM URL: https://principis.fedorapeople.org/pyznap-1.6.0-1.fc39.src.rpm
Description: 
pyznap is a ZFS snapshot management tool. It automatically takes and deletes
snapshots and can send them to different backup locations. You can specify a
policy for a given filesystem in the pyznap.conf file and then use cron to let
it run regularly.

Fedora Account System Username: principis

Comment 1 Fedora Review Service 2024-01-27 19:20:46 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6967306
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260650-pyznap/fedora-rawhide-x86_64/06967306-pyznap/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Arthur Bols 2024-03-11 12:44:34 UTC
- Added systemd services and timers
- Added patch: https://github.com/yboetz/pyznap/pull/101

Spec URL: https://principis.fedorapeople.org/pyznap.spec
SRPM URL: https://principis.fedorapeople.org/pyznap-1.6.0-1.fc39.src.rpm

Comment 3 Fedora Review Service 2024-03-11 12:51:25 UTC
Created attachment 2021113 [details]
The .spec file difference from Copr build 6967306 to 7136245

Comment 4 Fedora Review Service 2024-03-11 12:51:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7136245
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260650-pyznap/fedora-rawhide-x86_64/07136245-pyznap/fedora-review/review.txt

Found issues:

- Systemd service file(s) in pyznap
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fedora Review Service 2024-03-11 12:59:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7136278
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260650-pyznap/fedora-rawhide-x86_64/07136278-pyznap/fedora-review/review.txt

Found issues:

- Systemd service file(s) in pyznap
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Package Review 2025-03-12 00:45:24 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.