Bug 226072

Summary: Merge Review: libXfontcache
Product: [Fedora] Fedora Reporter: Nobody's working on this, feel free to take it <nobody>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED RAWHIDE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: sandmann
Target Milestone: ---Flags: panemade: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2008-01-15 04:28:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nobody's working on this, feel free to take it 2007-01-31 19:30:40 UTC
Fedora Merge Review: libXfontcache

http://cvs.fedora.redhat.com/viewcvs/devel/libXfontcache/
Initial Owner: sandmann

Comment 1 Parag AN(पराग) 2008-01-13 07:49:32 UTC
Review:
+ package builds in mock (rawhide i386).
+ rpmlint output is ok to accept
libXfontcache.i386: W: obsolete-not-provided XFree86-libs
libXfontcache.i386: W: obsolete-not-provided xorg-x11-libs
libXfontcache.src:18: W: unversioned-explicit-obsoletes XFree86-libs
libXfontcache.src:18: W: unversioned-explicit-obsoletes xorg-x11-libs
libXfontcache.src:31: W: unversioned-explicit-obsoletes XFree86-devel
libXfontcache.src:31: W: unversioned-explicit-obsoletes xorg-x11-devel
libXfontcache-devel.i386: W: obsolete-not-provided XFree86-devel
libXfontcache-devel.i386: W: obsolete-not-provided xorg-x11-devel
+ source match upstream
1adca018aa7bf2d215f20a69c10828ad  libXfontcache-1.0.4.tar.bz2

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags are used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains contents.
+ no static libraries.
+ xfontcache.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ ldconfig scriptlets are used.
+ Package libXfontcache-1.0.4-4.fc9 =>
  Provides: libXfontcache.so.1
  Requires: libX11.so.6 libXext.so.6 libXfontcache.so.1 libc.so.6
libc.so.6(GLIBC_2.1.3) rtld(GNU_HASH)
+ Package libXfontcache-devel-1.0.4-4.fc9 =>
  Requires(pre): xorg-x11-filesystem >= 0.99.2-3
Requires: libXfontcache = 1.0.4-4.fc9 libXfontcache.so.1 pkgconfig
xorg-x11-proto-devel
+ Not a GUI app.

APPROVED.