Bug 2260853

Summary: Review Request: ghc-language-c99-util - C99 implementation utilities
Product: [Fedora] Fedora Reporter: Frank Dedden <frank>
Component: Package ReviewAssignee: Jens Petersen <petersen>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: haskell-devel, package-review
Target Milestone: ---Flags: petersen: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://hackage.haskell.org/package/%{pkg_name}
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-05-19 15:43:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
.spec file
none
.srpm file none

Description Frank Dedden 2024-01-29 13:00:39 UTC
Created attachment 2011365 [details]
.spec file

CC: haskell-devel.org
Fedora Account System Username: fdedden
Description:
This library contains a number of utility functions and wrappers for the 'language-c99' package. For an actual high-level approach to writing C99 programs, see 'language-c99-simple'.

Comment 1 Frank Dedden 2024-01-29 13:01:31 UTC
Created attachment 2011366 [details]
.srpm file

Comment 2 Frank Dedden 2024-01-29 13:08:02 UTC
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=112541808

Comment 3 Jens Petersen 2024-02-27 10:16:58 UTC
Sorry, is it possible you could upload the spec and srpm to fedorapeople.org (or somewhere else)?
Now that you are a Packager you should have ssh access to fedorapeople.org.

One way to do this is in future to use `fedora-create-review spec srpm` (or `fbrnch create-review`).
But since you already opened this and other review requests, you can use `fbrnch update-review`
to do that (no need to bump anything).

Comment 5 Frank Dedden 2024-03-03 16:51:33 UTC
Thanks for your response. Back when I posted this review, the fedorapeople.org server was unreachable, so I uploaded them here by hand. I have added the .spec and .src.rpm using your method now.

Comment 6 Fedora Review Service 2024-03-03 18:46:51 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7099420
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260853-ghc-language-c99-util/fedora-rawhide-x86_64/07099420-ghc-language-c99-util/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Jens Petersen 2024-05-11 11:04:28 UTC
Sorry for taking so long to get back to this - work has been really busy.

Package complies with packaging guidelines and installs.
Spec file generated with cabal-rpm.
License is MIT, authored by submitter

Package APPROVED

Comment 8 Fedora Admin user for bugzilla script actions 2024-05-15 18:43:45 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-language-c99-util

Comment 9 Frank Dedden 2024-05-19 15:43:27 UTC
Thanks Jens, the package has been added successfully!