Bug 226102

Summary: Merge Review: lockdev
Product: [Fedora] Fedora Reporter: Nobody's working on this, feel free to take it <nobody>
Component: Package ReviewAssignee: Miroslav Lichvar <mlichvar>
Status: CLOSED RAWHIDE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jpopelka, kzak, mlichvar
Target Milestone: ---Flags: mlichvar: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-12-09 12:48:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Nobody's working on this, feel free to take it 2007-01-31 19:34:40 UTC
Fedora Merge Review: lockdev

Initial Owner: kzak@redhat.com

Comment 1 Miroslav Lichvar 2009-12-01 14:09:40 UTC
Review follows:

NO source files match upstream.
- source URL gives 404

YES package meets naming and versioning guidelines.
YES specfile is properly named, is cleanly written and uses macros consistently.
YES dist tag is present.
YES build root is correct. (no build root specified)
NO license field matches the actual license.
- the actual license seems to be LGPLv2, under LGPLv2+ is licensed only baudboy.h
YES license is open source-compatible.
NO License text included in package.
NO latest version is being packaged.
- is there a reason for not packaging 1.0.3?
YES BuildRequires are proper.
YES compiler flags are appropriate.
YES %clean is present.
YES package builds in mock (Rawhide/x86_64).
YES debuginfo package looks complete.
YES rpmlint output is sane.
lockdev.x86_64: E: setgid-binary /usr/sbin/lockdev lock 02711
lockdev.x86_64: E: non-standard-executable-perm /usr/sbin/lockdev 02711
lockdev.x86_64: E: non-standard-executable-perm /usr/sbin/lockdev 02711

These are ok.

YES final provides and requires look sane.
N/A %check is present and all tests pass.
YES shared libraries are added to the regular linker search paths, ldconfig called in %post and %postun.
YES owns the directories it creates.
YES doesn't own any directories it shouldn't.
YES no duplicates in %files.
YES file permissions are appropriate.
YES code, not content.
YES documentation is small, so no -docs subpackage is necessary.
- documentation should include some files like AUTHORS, ChangeLog
YES %docs are not necessary for the proper functioning of the package.
YES headers packaged in -devel subpackage
YES no pkgconfig files.
YES no libtool .la droppings.
YES not a GUI app.

Comment 2 Jiri Popelka 2009-12-08 13:05:42 UTC
All problems should be fixed in lockdev-1.0.3-1.fc13.

Comment 3 Miroslav Lichvar 2009-12-09 12:48:13 UTC
OK source files match upstream.
64b9c1b87b125fc348e892e24625524a  lockdev_1.0.3.orig.tar.gz

OK License text included in package.
- maybe would be good to include also AUTHORS and Changelog
OK latest version is being packaged.

Looks ok, approved.