Bug 226120
| Summary: | Merge Review: make | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Miroslav Lichvar <mlichvar> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | pmachata, redhat-bugzilla |
| Target Milestone: | --- | Flags: | mlichvar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | F 8 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-05 15:10:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 19:36:53 UTC
Tidied up version commited, not built. rpmlint is silent, for both source and binary rpm. I'll look into this. OK:
- rpmlint is silent
- the package is named according to the Package Naming Guidelines
- the spec file name matches the base package %{name}
- the package is licensed with a Fedora approved license
- the License field in the package spec file matches the actual license (GPLv2+)
- the spec file is written in American English
- the spec file for the package is legible
- the sources used to build the package matches the upstream source
- all build dependencies are listed in BuildRequires
- the spec file handles locales properly
- the package owns all directories that it creates
- the package does not contain any duplicate files in the %files listing
- permissions on files are set properly
- the package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT
- the package consistently uses macros
- the package contains code, or permissible content
- files included as %doc don't affect the runtime of the application
- the package does not own files or directories already owned by other packages
- at the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT
- all filenames in the package are valid UTF-8
- scriptlets are sane
Need some work:
- please add COPYING and AUTHORS files to %doc
- unused siglist patch should be removed in CVS
- would be nice to have a symlink for man page gmake.1.gz -> make.1.gz
- please consider removing the first hunk in the noclock patch and removing the
config/missing calls as nothing else is touching configure.in
- I'd suggest removing the second paragraph from the package description, users
don't really need to have make installed
I cleaned up the spec per your comments and committed it. Approved. Built. |