Bug 226148

rpmlint on binary rpm gave
mlocate.i386: W: non-standard-gid /var/lib/mlocate slocate
A file in this package is owned by a non standard group. Standard groups are:
root, bin, daemon, sys, adm, tty, disk, lp, mem, kmem, wheel, mail, news,
uucp, man, games, gopher, dip, ftp, lock, nobody, users.

mlocate.i386: E: non-standard-dir-perm /var/lib/mlocate 0750
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.

mlocate.i386: W: non-standard-gid /usr/bin/locate slocate
A file in this package is owned by a non standard group. Standard groups are:
root, bin, daemon, sys, adm, tty, disk, lp, mem, kmem, wheel, mail, news,
uucp, man, games, gopher, dip, ftp, lock, nobody, users.

mlocate.i386: E: setgid-binary /usr/bin/locate slocate 02711
The file is setgid. Usually this is a packaging bug. If this is a game,  then,
you should use the proper rpm group, or location.

mlocate.i386: E: non-standard-executable-perm /usr/bin/locate 02711
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.

mlocate.i386: E: non-standard-executable-perm /usr/bin/locate 02711
A standard executable should have permission set to 0755. If you get this
message, it means that you have a wrong executable permissions in some files
included in your package.
==> I guess above are ok for this package.

mlocate.i386: W: spurious-bracket-in-%post
The %post scriptlet contains an "if []" construct without a space before the
"]".
== > Not sure if this fix is really required here.

Created attachment 327789 [details]
Cleanup suggested following packaging guidelines

Following changes are done in patch

1)For group creation here is guidelines 
https://fedoraproject.org/wiki/Packaging/UsersAndGroups

2)Added macros as per given at https://fedoraproject.org/wiki/Packaging/RPMMacros#Macros_mimicking_autoconf_variables

3) preserve timestamp http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps

ping?

Thanks for the patch.  I have applied most of it in mlocate-0.21.1-3, with the following changes:
- add "exit 0" to %triggerpostun as well
- Don't replace /etc/cron.daily by %{_sysconfdir}/cron.daily.
  Somebody might reasonably redefine %{_bindir} etc. to e.g. build a mlocate
  package located under /opt/mlocate, but the cron.daily script must be in
  /etc/cron.daily, where it is expected by cron configuration, not in
  /opt/mlocate/etc/cron.daily, for example.

APPROVED.
You can think of adding disttag. Its not mandatory though.
Once you build this new package in rawhide, you can close this review.