Bug 226152

staring review for this package.Also I would like to needinfo package owner so that he will not miss about this review.

Created attachment 350571 [details]
modified spec file 

Can you commit attached patch that fixes most of things according to packaging guidelines?

Comment on attachment 350571 [details]
modified spec file 

>--- mod_auth_mysql.spec	2009-02-26 07:23:21.000000000 +0530
>+++ mod_auth_mysql-new.spec	2009-07-06 11:33:45.000000000 +0530
>@@ -1,18 +1,18 @@
> Summary: Basic authentication for the Apache web server using a MySQL database
> Name: mod_auth_mysql
> Version: 3.0.0
>-Release: 8
>+Release: 9%{?dist}
> Epoch: 1
> Group: System Environment/Daemons
> URL: http://modauthmysql.sourceforge.net/
>-Source: mod_auth_mysql-%{version}.tar.gz
>+Source: http://downloads.sourceforge.net/modauthmysql/mod_auth_mysql-%{version}.tar.gz
> Source2: auth_mysql.conf
> Patch0: mod_auth_mysql-3.0.0-apr1x.patch
> Patch1: mod_auth_mysql-3.0.0-disable.patch
> License: ASL 1.1
> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> BuildRequires: httpd-devel, mysql-devel
>-Requires: httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing httpd-devel)
>+Requires: httpd-mmn
> 
> %description
> mod_auth_mysql can be used to limit access to documents served by a
>@@ -28,17 +28,17 @@
>         -c %{name}.c -L%{_libdir}/mysql -lmysqlclient
> 
> %install
>-[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
>+rm -rf $RPM_BUILD_ROOT
> mkdir -p $RPM_BUILD_ROOT%{_libdir}/httpd/modules
> install -m755 .libs/%{name}.so $RPM_BUILD_ROOT%{_libdir}/httpd/modules
> 
> # Install the config file
> mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/httpd/conf.d
>-install -m 644 $RPM_SOURCE_DIR/auth_mysql.conf \
>+install -p -m 644 %{SOURCE1} \
>    $RPM_BUILD_ROOT%{_sysconfdir}/httpd/conf.d/
> 
> %clean
>-[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
>+rm -rf $RPM_BUILD_ROOT
> 
> %files
> %defattr(-,root,root)
>@@ -47,6 +47,9 @@
> %config(noreplace) %{_sysconfdir}/httpd/conf.d/*.conf
> 
> %changelog
>+* Mon Jul 06 2009 Joe Orton <jorton> 1:3.0.0-9
>+- Spec cleanup
>+
> * Wed Feb 25 2009 Fedora Release Engineering <rel-eng.org> - 1:3.0.0-8
> - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
>

updated attachment as rpmlint complained on srpm that results to change
$RPM_SOURCE_DIR/auth_mysql.conf
to
%{SOURCE1}

as done in above comment.

Looks good other than:

>-Requires: httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing httpd-devel)
>+Requires: httpd-mmn

which is a regression - leave that line as-is.

(In reply to comment #5)
> Looks good other than:
> 
> >-Requires: httpd-mmn = %(cat %{_includedir}/httpd/.mmn || echo missing httpd-devel)
> >+Requires: httpd-mmn
> 
> which is a regression - leave that line as-is.  

I didn't get how is this regression and why we need that much long line in Requires?

As I am reviewing this package, I cannot apply changes to this package even if I don't need co-ownership for this package as I am in provenpackager group.

Can you commit changes then?

I guess I can commit as you have reviewed patch and allowed me to do so. Will commit now.

I have committed changes in cvs. Can you build new release in rawhide?

http://koji.fedoraproject.org/koji/buildinfo?buildID=126147
Package built in rawhide is now APPROVED.