Bug 226155 (mod_perl)

mod_perl.src:55: W: rpm-buildroot-usage %build PREFIX=$RPM_BUILD_ROOT/usr \
mod_perl.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 55)
mod_perl.src: W: strange-permission filter-provides.sh 0775
mod_perl.src: W: strange-permission filter-requires.sh 0775

mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-inline
mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-register
mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-xs
mod_perl.i386: E: wrong-script-interpreter
/usr/share/doc/mod_perl-2.0.4/docs/os/win32/mpinstall "C:/Perl/bin"
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/c.pod
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/Changes
mod_perl.i386: W: hidden-file-or-dir
/usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-init
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/docs/user/Changes.pod
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/SVN-MOVE
mod_perl.i386: W: file-not-utf8
/usr/share/doc/mod_perl-2.0.4/docs/devel/core/explained.pod
mod_perl.i386: E: useless-explicit-provides perl(Apache2::Connection)
mod_perl.i386: E: useless-explicit-provides perl(Apache2::RequestRec)

spec:
missing dist tag

Hi.

I am using 

mod_perl-2.0.4-6.x86_64
httpd-2.2.9-4.x86_64

and I receiving the flowing error.


[root@localhost ~]# service httpd restart
Stopping httpd:                                            [FAILED]
Starting httpd: httpd: Syntax error on line 209 of /etc/httpd/conf/httpd.conf: Syntax error on line 10 of /etc/httpd/conf.d/perl.conf: Cannot load /etc/httpd/modules/mod_perl.so into server: /etc/httpd/modules/mod_perl.so: undefined symbol: modperl_io_perlio_restore_stdout
                                                           [FAILED]


Can you help with this issue, or Can I open a new bug report ?

I opened new bug #465743 for this problem.

Created attachment 362781 [details]
Patch to the mod_perl spec file

Here's a patch that removes all the errors that can be removed.

Joe, per the recent discussion on devel.o on merge reviews, do you think we can get this one closed ? I'ld gladly review it if so.

Emmanuel - if you are a provenpackager please go ahead and commit your fixes, if not please request commit privs for this package and I'll approve that!

(In reply to comment #7)
>
> Emmanuel - if you are a provenpackager please go ahead and commit your fixes,
> if not please request commit privs for this package and I'll approve that!    

This kind of defeats the point of having merge reviews. The whole point is that two people collaborate on raising the package's quality level.

http://lists.fedoraproject.org/pipermail/devel/2010-July/138649.html

That said, the changes look to be minor. Would anybody else care to review the package so that I can play the part of the maintainer ?

Emmanuel,
  Its official that if maintainer approves reviewer to commit on behalf of him then please go ahead and commit the changes and close yourself this review. 
  This has been approved in http://lists.fedoraproject.org/pipermail/devel/2010-August/141204.html

Let's help merge-review maintainers to review their packages by committing approved changes by them and reviewing their packages.

Hello Emmanuel,
I can review it again.
rpmlint mod_perl-2.0.4-11.fc15.src.rpm 
mod_perl.src: W: spelling-error %description -l en_US perl -> Perl, peel, perk
mod_perl.src: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish
mod_perl.src: W: strange-permission filter-provides.sh 0755L
mod_perl.src: W: strange-permission filter-requires.sh 0755L
mod_perl.src:59: W: rpm-buildroot-usage %build PREFIX=$RPM_BUILD_ROOT/usr \
mod_perl.src:108: W: macro-in-comment %{_mandir}
mod_perl.src:109: W: macro-in-comment %{perl_vendorarch}
mod_perl.src:59: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 59)
1 packages and 0 specfiles checked; 0 errors, 8 warnings.
rpmlint i386/* | grep -v private
mod_perl.i386: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish
mod_perl.i386: E: useless-provides perl(Apache2::Connection)
mod_perl.i386: E: useless-provides perl(Apache2::RequestRec)
mod_perl.i386: W: hidden-file-or-dir /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-inline
mod_perl.i386: W: hidden-file-or-dir /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-register
mod_perl.i386: W: hidden-file-or-dir /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-xs
mod_perl.i386: E: wrong-script-interpreter /usr/share/doc/mod_perl-2.0.4/docs/os/win32/mpinstall C:/Perl/bin
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/c.pod
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/Changes
mod_perl.i386: W: hidden-file-or-dir /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-init
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/docs/user/Changes.pod
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/SVN-MOVE
mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/docs/devel/core/explained.pod
mod_perl.i386: W: no-manual-page-for-binary mp2bug
And there is also a lot of *.so in provides. This could be easily filtered by perl_default_filter.
That's for start ;-)

Ping Emmanuel, do you want still fix it?

(In reply to comment #11)
>
> Ping Emmanuel, do you want still fix it?

Yup, I've just been busy these last two weeks and haven't had time to spare to reviews. I'll make time by the end of the week.

Created attachment 456737 [details]
Patch to mod_perl.spec

Created attachment 456738 [details]
The new spec file

(In reply to comment #12)
>
> Yup, I've just been busy these last two weeks and haven't had time to spare to
> reviews. I'll make time by the end of the week.

Well, make that next week. :-)

(In reply to comment #10)
>
> mod_perl.src: W: spelling-error %description -l en_US perl -> Perl, peel, perk

False positive.

> mod_perl.src: W: spelling-error %description -l en_US runtime -> run time,
> run-time, runtish

Fixed.

> mod_perl.src: W: strange-permission filter-provides.sh 0755L
> mod_perl.src: W: strange-permission filter-requires.sh 0755L

Removed (see below).

> mod_perl.src:59: W: rpm-buildroot-usage %build PREFIX=$RPM_BUILD_ROOT/usr \

Not fixed (and harmless, imho).

> mod_perl.src:108: W: macro-in-comment %{_mandir}
> mod_perl.src:109: W: macro-in-comment %{perl_vendorarch}

Removed.

> mod_perl.src:59: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 59)

Ugh. Fixed.

> mod_perl.i386: E: useless-provides perl(Apache2::Connection)
> mod_perl.i386: E: useless-provides perl(Apache2::RequestRec)

Filtered. I also moved the filtering inline.

> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-inline
> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-register
> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-xs
> mod_perl.i386: E: wrong-script-interpreter

False postives.

> /usr/share/doc/mod_perl-2.0.4/docs/os/win32/mpinstall C:/Perl/bin

False positive.

> mod_perl.i386: W: file-not-utf8
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/c.pod
> mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/Changes
> mod_perl.i386: W: hidden-file-or-dir
> /usr/share/doc/mod_perl-2.0.4/docs/devel/debug/code/.debug-modperl-init
> mod_perl.i386: W: file-not-utf8
> /usr/share/doc/mod_perl-2.0.4/docs/user/Changes.pod
> mod_perl.i386: W: file-not-utf8 /usr/share/doc/mod_perl-2.0.4/SVN-MOVE
> mod_perl.i386: W: file-not-utf8
> /usr/share/doc/mod_perl-2.0.4/docs/devel/core/explained.pod

All fixed.

> mod_perl.i386: W: no-manual-page-for-binary mp2bug

Probably something to report to upstream.

Buildroot and rm -rf in build section are not needed since F-13. These could be removed, but everything else looks allright.

Created attachment 457786 [details]
New patch to the spec file

(In reply to comment #16)
>
> Buildroot and rm -rf in build section are not needed since F-13. These could be
> removed, but everything else looks allright.

You're right. The new patch does this (and adds the correct changelog).
Can you commit this ? I don't have provenpackager rights.

(In reply to comment #17)
> Created attachment 457786 [details]
> New patch to the spec file
> 
> (In reply to comment #16)
> >
> > Buildroot and rm -rf in build section are not needed since F-13. These could be
> > removed, but everything else looks allright.
> 
> You're right. The new patch does this (and adds the correct changelog).
> Can you commit this ? I don't have provenpackager rights.

Built in rawhide.

mod_perl has broken dependencies in the rawhide tree:
On x86_64:
        mod_perl-devel-2.0.4-12.fc15.x86_64 requires perl(Apache::TestConfigPerl)
        mod_perl-devel-2.0.4-12.fc15.x86_64 requires perl(Apache::TestConfigParse)
        mod_perl-devel-2.0.4-12.fc15.x86_64 requires perl(Data::Flow)

Should be fixed in last commit. I'm sorry, we missed these.

Hi Guys,

i'm having issues with the package mod_perl (mod_perl-2.0.5-5).  The httpd service crashed after installed

The httpd version is 2.2.21 and this is the error message i'm getting everytime I tried to run the service:


Restarting httpd (via systemctl):  Job failed. See system logs and 'systemctl status' for details.
                                                           [FAILED]
# systemctl status httpd

# systemctl status httpd.service 
httpd.service - The Apache HTTP Server (prefork MPM)
      Loaded: loaded (/lib/systemd/system/httpd.service; enabled)
      Active: failed since Wed, 19 Oct 2011 16:40:07 -0500; 27s ago
     Process: 5233 ExecStop=/usr/sbin/httpd $OPTIONS -k stop (code=exited, status=0/SUCCESS)
     Process: 5235 ExecStart=/usr/sbin/httpd $OPTIONS -k start (code=dumped, signal=SEGV)
    Main PID: 4794 (code=exited, status=0/SUCCESS)
      CGroup: name=systemd:/system/httpd.service

Please let me know if you need more details

mod_perl-2.0.10-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4e7927a6eb

mod_perl-2.0.10-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4e7927a6eb

mod_perl-2.0.10-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.