Bug 226180
| Summary: | Merge Review: mysql | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hhorak, mattdm, oget.fedora, redhat-bugzilla |
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-04-02 17:45:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 223713 | ||
| Bug Blocks: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:14:30 UTC
The full review arrived!
* Summary and especially the description are bizarre. Can you update them. You can find these on the manpage:
Xinerama - API for Xinerama extension to X11 Protocol
Xinerama is a simple library designed to interface the Xinerama Extension for
retrieving information about physical output devices which may be combined
into a single logical X screen.
* rpmlint says
libXinerama.src:18: W: unversioned-explicit-obsoletes XFree86-libs
libXinerama.src:18: W: unversioned-explicit-obsoletes xorg-x11-libs
libXinerama.src:32: W: unversioned-explicit-obsoletes XFree86-devel
libXinerama.src:32: W: unversioned-explicit-obsoletes xorg-x11-devel
libXinerama.x86_64: E: zero-length /usr/share/doc/libXinerama-1.0.3/AUTHORS
libXinerama.x86_64: E: zero-length /usr/share/doc/libXinerama-1.0.3/README
libXinerama.x86_64: W: obsolete-not-provided XFree86-libs
libXinerama.x86_64: W: obsolete-not-provided xorg-x11-libs
libXinerama-devel.x86_64: W: obsolete-not-provided XFree86-devel
libXinerama-devel.x86_64: W: obsolete-not-provided xorg-x11-devel
The zero-length files are obviously not needed so they should be removed. The obsoletes look very problematic. Can you fix those (or alternatively explain them in the SPEC file as comments)?
* BR: libXau-devel is not needed. Afaict it is not used.
* BRs: libX11-devel pkgconfig and xorg-x11-proto-devel are not needed. They will be picked up by libXext-devel.
* Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). This applies to the devel package.
! Try to make use of the %{name} macro (e.g. files sections).
* Parallel make must be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment.
Added Adam and Matthias to CC since they are the last two known maintainers. Sorry if this was not desired.
Shoot! Wrong bug. Sorry for the mess. I'll review this next. I can't find the koji entry for the new version.. I guess it is still being worked on. fitzsim, can you provide a SRPM when you're done? No longer in Fedora. |