Bug 226269
| Summary: | Merge Review: perl-libxml-perl | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | robin.norwood |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-12 10:36:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:36:40 UTC
1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl >= 1:5.6.1 2)drop "|| :" from %check 3)you may like to add disttag 4)rpmlint only complained -> perl-libxml-perl.noarch: E: useless-explicit-provides perl(Data::Grove) This package provides 2 times the same capacity. It should only provide it once. perl-libxml-perl.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. All of the above should be fixed in the latest version: perl-libxml-perl-0.08-3.fc9 Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 0ed5fbdda53d1301ddaed88db10503bb libxml-perl-0.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/amsterdam...........ok t/canon_xml_writer....ok t/schema..............ok t/stream..............ok t/subs................ok t/xp_sax..............ok All tests successful. Files=6, Tests=45, 0 wallclock secs ( 0.28 cusr + 0.07 csys = 0.35 CPU) + Package perl-libxml-perl-0.08-3.fc8 -> Provides: perl(Data::Grove::Characters) perl(Data::Grove::Parent) = 0.08 perl(Data::Grove::ParentList) perl(Data::Grove::Visitor) = 0.08 perl(XML::ESISParser) = 0.08 perl(XML::Handler::CanonXMLWriter) = 0.08 perl(XML::Handler::Sample) perl(XML::Handler::Subs) = 0.08 perl(XML::Handler::XMLWriter) = 0.08 perl(XML::Parser::PerlSAX) = 0.08 perl(XML::PatAct::ACTION) perl(XML::PatAct::Amsterdam) = 0.08 perl(XML::PatAct::MatchName) = 0.08 perl(XML::PatAct::PATTERN) perl(XML::PatAct::ToObjects) = 0.08 perl(XML::Perl2SAX) = 0.08 perl(XML::SAX2Perl) = 0.08 Requires: perl >= 0:5.005 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(IO::File) perl(UNIVERSAL) perl(XML::Handler::Subs) perl(XML::Parser) perl(strict) perl(vars) APPROVED. Can we CLOSE this review if package is already built and in rawhide? |