Bug 226270 (perl-Net-DNS)
| Summary: | Merge Review: perl-Net-DNS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> | ||||
| Component: | Package Review | Assignee: | Jochen Schmitt <jochen> | ||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | cweyl, ppisar, pwouters, redhat-bugzilla, robin.norwood | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | Flags: | jochen:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-10-24 03:25:05 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:36:43 UTC
Good:
+ Rpmlint quite on source rpm
+ Tar ball matches with upstream.
+ License ok.
+ Local build works fine.
+ Rpmlint quite for binary package
+ Rpmlint quite for debuginfo package.
Bad:
- Wrong Buildroot:
uildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
(wiki: PackagingGuidelines#BuildRoot)
- Perl must not be included as an BR.
BuildRequires: perl should not be included
(wiki: Packaging/Guidelines#Exceptions)
- Package contains no verbatin copy of the license text.
- Mock build failed
Created attachment 151589 [details]
log of failed mock build
Can you post the root.log as well? I'm curious as to how the buildreq perl-Net-IP was satisfied since the absence of this module is what caused the build to fail. (the perl-Net-IP buildreq should really be perl(Net::IP) of course) o Fixed the buildroot ------ This string is in the README: """ All rights reserved. This program is free software; you may redistribute it and/or modify it under the same terms as Perl itself. """ Which is sufficient for perl packages - the text of the license doesn't have to be included unless it is included in the source tarball. ------- o I can't reproduce the build failure you show maybe the root.log that Paul requests in comment #3 will help. o Fixed the BuildRequires - removed 'perl', and changed the others to the perl(Module::Name) format. ------- 0.59-2.fc7 should fix these issues - if the mock build failure is geniune, we can look at the root.log and maybe figure out what's up. Good: + Rpmlint quite on source package. + Rpmlint quite on binary package. + Rpmlint quite on debuginfo package. + Local install/update of package works fine. + Build on Mock works fine. *** APPROVED *** Package Change Request ====================== Package Name: perl-Net-DNS New Branches: el-5 el-6 Owners: mmaslano pwouters InitialCC: mmaslano perl-Net-DNS is needed as dependancy for perl-Net-DNSSEC which is already in el-5/el-6 but cannot be build now due to this missing dependancy. It does not matter to me who will be the owner. It can be the original package owner, or I can take it on, or we can co-maintain.... Erm, no, perl-Net-DNS is as far as I can tell a part of base RHEL. We can't branch it for EPEL. ok. i guess perl-Net-DNS-SEC should be removed from el-5 then. I'll look into it. Package Change Request ====================== Package Name: perl-Net-DNS Branches: f16 f17 f18 Owners: InitialCC: perl-sig Please add perl-sig user with watch* permissions only to all Fedora branches. Done. |