Bug 226273
Summary: | Merge Review: perl-Net-Telnet | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> | ||||
Component: | perl-Net-Telnet | Assignee: | Fabio Massimo Di Nitto <fdinitto> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | cfeist, fdinitto, mastahnke | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2008-07-09 05:13:23 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:37:02 UTC
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should package latest version OK - check for outstanding bugs on package. (For core merge reviews) Issues: XX -- License is GPL or Artistic, not sure if that is valid. XX -- License (GPL or Artistic) Not include in package (%doc area) XX -- Should have dist tag XX -- MANIFEST shouldn't be included in Perl modules. [builder@rawhide noarch]$ rpmlint perl-Net-Telnet-3.03-5.noarch.rpm E: perl-Net-Telnet description-line-too-long Net::Telnet allows you to make client connections to a TCP port and do network I/O, E: perl-Net-Telnet description-line-too-long especially to a port using the TELNET protocol. Simple I/O methods such as print, E: perl-Net-Telnet description-line-too-long get, and getline are provided. More sophisticated interactive features are provided E: perl-Net-Telnet description-line-too-long because connecting to a TELNET port ultimately means communicating with a program E: perl-Net-Telnet description-line-too-long designed for human interaction. These interactive features include the ability to E: perl-Net-Telnet description-line-too-long specify a time-out and to wait for patterns to appear in the input stream, such as W: perl-Net-Telnet manifest-in-perl-module /usr/share/doc/perl-Net-Telnet-3.03/MANIFEST [builder@rawhide noarch]$ [builder@rawhide SRPMS]$ rpmlint -I manifest-in-perl-module manifest-in-perl-module : This perl module package contains a MANIFEST or a MANIFEST.SKIP file in the documentation directory. [builder@rawhide SRPMS]$ rpmlint perl-Net-Telnet-3.03-5.src.rpm E: perl-Net-Telnet description-line-too-long Net::Telnet allows you to make client connections to a TCP port and do network I/O, E: perl-Net-Telnet description-line-too-long especially to a port using the TELNET protocol. Simple I/O methods such as print, E: perl-Net-Telnet description-line-too-long get, and getline are provided. More sophisticated interactive features are provided E: perl-Net-Telnet description-line-too-long because connecting to a TELNET port ultimately means communicating with a program E: perl-Net-Telnet description-line-too-long designed for human interaction. These interactive features include the ability to E: perl-Net-Telnet description-line-too-long specify a time-out and to wait for patterns to appear in the input stream, such as W: perl-Net-Telnet mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1) [builder@rawhide SRPMS]$ Sorry I had the wrong review flag here. Should be ?. Created attachment 306445 [details]
Clean up package as required by Review
Hi Jesse,
i have attached a patch that addresses all the problems reported in the review
and also a bunch of rpmlint warnings.
I don't have access to commit to this package directly. Please consider
applying.
Thanks
Fabio
Reassigning to perl-Net-Telnet. All the remaining bits have been fixed in rawhide with 3.03-7 build. Fabio |