Bug 2262748

Summary:	Review Request: ghc-BoundedChan - Implementation of bounded channels
Product:	[Fedora] Fedora	Reporter:	Frank Dedden <frank>
Component:	Package Review	Assignee:	Jens Petersen <petersen>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	haskell-devel, kevin, package-review
Target Milestone:	---	Flags:	petersen: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-06-24 07:28:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Frank Dedden 2024-02-05 09:01:06 UTC

Spec URL: https://fdedden.fedorapeople.org/ghc-BoundedChan.spec
SRPM URL: https://fdedden.fedorapeople.org/ghc-BoundedChan-1.0.3.0-1.fc40.src.rpm

Description:
This library introduces BoundedChan. BoundedChans differ from Chans in that
they are guaranteed to contain no more than a certain number of elements.

Fedora Account System Username: fdedden

Comment 1 Frank Dedden 2024-02-05 09:01:09 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=112961076

Comment 2 Jens Petersen 2024-05-27 16:23:49 UTC

The package complies with the packaging guidelines and installs.
Spec file is generated with cabal-rpm.
License is BSD3.

Package APPROVED

Comment 3 Frank Dedden 2024-06-01 08:02:25 UTC

Thanks for the approval!

I have requested a repo using `fedpkg request-repo ...`, but somehow it failed: https://pagure.io/releng/fedora-scm-requests/issue/62712. The repository is created, however it seems that it is owned by `releng-bot` and not me, therefore I can't clone it via SSH nor push anything to it: https://src.fedoraproject.org/rpms/ghc-BoundedChan/commits/rawhide

What can we fix this somehow?

Comment 4 Kevin Fenzi 2024-06-02 15:12:30 UTC

I've fixed this. Sorry for the trouble.

Comment 5 Frank Dedden 2024-06-07 12:52:22 UTC

Thanks a lot!

Apparently the package is not building anymore: https://koji.fedoraproject.org/koji/taskinfo?taskID=118703522, I have noticed the same with other packages that I am currently working on.

I assume it has to do with
```
RPM build errors:
error: Empty %files file /builddir/build/BUILD/ghc-BoundedChan-1.0.3.0-build/BoundedChan-1.0.3.0/debugsourcefiles.list
    Empty %files file /builddir/build/BUILD/ghc-BoundedChan-1.0.3.0-build/BoundedChan-1.0.3.0/debugsourcefiles.list
Child return code was: 1
```

I am not sure why this is a problem all of a sudden. I tried regenerate the .spec file, but that one fails with the same error. Has something changed in Fedora since the start of this request?

Comment 6 Frank Dedden 2024-06-24 07:28:28 UTC

I have successfully build the package, and added it to rawhide: https://src.fedoraproject.org/rpms/ghc-BoundedChan.

Comment 7 Jens Petersen 2024-06-24 07:35:26 UTC

(Ah sorry missed that comment - do ping me next time :)

Yes, I fixed that independently recently (it was due to some small change in latest rpm behavior:
was fixed in ghc-rpm-macros-2.7.1-1.fc41