Bug 226275

rpmlint:

W: perl-PDL macro-in-%changelog description

- can be ignored

W: perl-PDL mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3)

- Fixed in patch

I think the Summary should be changed to something like "The Perl Data Language".

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL/Artistic) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

Consider including some more files in %doc:
BUGS
Changes
Known_problems
Release_Notes

A number of PDL modules are not being built that could be.  I'll be attaching a
number of patches that enable them as well as getting PDL to build for devel again.

Created attachment 160366 [details]
patch to devel

Patch to spec and perl-PDL-settings.patch that:

- turns on 3D/GL
- turns on IO Browser
- changes tabs to spaces
- adds a bunch of BRs to enable more modules
- removes unneeded Provides

Created attachment 160367 [details]
patch to look for hdf devel files in the right place

Created attachment 160368 [details]
patch to fix some tests

Created attachment 160369 [details]
patch to find 64-bit libraries for certain modules

Looks like we also need a BR: libGLU-devel

Make that BR: libGLU-devel libGL-devel - though GLU depended on GL, but I guess not.

Created attachment 160436 [details]
Remove -lXext library

Scratch the BR libGL-devel, real fix is to remove -lXext from the GL linking
options.

ok, applied your patches, added the additional files to %docs, fixed the
'unescaped % in %changelog' warning, and a non-UTF-8 PDL::Complex.3pm.

However, rpmlint is still complaining about:

W: perl-PDL unversioned-explicit-provides perl(PDL::Config)
etc...

And company.  Wouldn't it be better to version these with the same version as
perl-PDL?

also rpmlint complains about:

W: perl-PDL devel-file-in-non-devel-package
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/PDL/Core/pdlsimple.h
etc...

We could probably move these to a perl-PDL-devel package, if they aren't needed
at runtime.

(In reply to comment #9)
> 
> However, rpmlint is still complaining about:
> 
> W: perl-PDL unversioned-explicit-provides perl(PDL::Config)
> etc...
> 
> And company.  Wouldn't it be better to version these with the same version as
> perl-PDL?

Well, the vast majority of the automatic perl provides are unversioned too, so
my take would be to leave the version out for now.

> also rpmlint complains about:
> 
> W: perl-PDL devel-file-in-non-devel-package
> /usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/PDL/Core/pdlsimple.h
> etc...
> 
> We could probably move these to a perl-PDL-devel package, if they aren't needed
> at runtime.
> 

Not according to:

http://fedoraproject.org/wiki/PackagingDrafts/Perl#head-b867c6067f009c5ea8f21723d028e8b40fae15c7


Some more stuff:

- I've got perl-ExtUtils-F77 added to Fedora, so we can add:

BuildRequires: perl(ExtUtils::F77)
BuildRequires: gcc-gfortran

I'll also attach a patch that uses the RPM_OPT_FLAGS and -fPIC to compile to
fortran code, and fixes a test for gfortran/f77 compatibility.

This allows PDL::Slatec to build, so we can remove that from the listed Provides.

- Still need BuildRequires: libGLU-devel

- Looks like the License should be re-examined and the tag updated.  Possibly
"GPL+ or Artistic" though some files seem a little different.

- Looks like we need to add Provides: perl(PDL::Graphics::TriD::Objects)

- We need to filter perl(Win32::DDE::Client) from Requires now.

- Don't forget to bump release and add changelog entries!

I'll attach a patch for my spec changes as well.

Created attachment 161017 [details]
Patch to spec

Created attachment 161018 [details]
patch to fix fortran issues

Awesome.

Applied your patch, except for the change to the License field.  I've pinged Tom
Callaway to take a look at the license first.  Looks like the standard 'same
terms as perl itself' to me - plus the one public domain image.

Tom confirmed that you are correct about the license issue, I'll fix it.  Also,
it is failing to build in the buildsystem.  I'll take a look and try to fix it
today.

Created attachment 161309 [details]
Updated test patch

Looks like ppc is pickier about test output for some reason.  This updated
patch shuts up xvals.t some more.  With this change it builds for me on ppc and
ppc64.

Excellent, thanks.  2.4.3-4 should be in rawhide now.  Please take a look.

By the by, are any of these patches submitted upstream?  Looks like some of them
would be appropriate.

Looks good to me.  APPROVED.

I haven't sent any patches upstream, I haven't yet managed to subscribe to
PDL-porters.  Looks like that there are similar patches for some of this issues
in upstream CVS.  I would be nice if they did a new release, it's been almost a
full year since the last one.

I'd love to see this make it into EPEL for EL-5 at least.

"I'd love to see this make it into EPEL for EL-5 at least."

If someone were to file a bug for that, I'd be happy to take a look at it.

I'm guessing the deps will be a pain, though.

Created attachment 293304 [details]
patch to support EL-5 GL lib

All necessary dependencies for perl-PDL are now in EPEL-5.  The attached patch
is necessary to handle the version of GL in EL-5.  With this patch, it builds
fine for me.

Package Change Request
======================
Package Name: perl-PDL
New Branches: EL-5


There we go.

Orion, would you like to maintain or co-maintain this package in EPEL and/or
Fedora?  I don't actually use it, so you'll probably do a much better job than I
at maintaining it.

(In reply to comment #20)
> Orion, would you like to maintain or co-maintain this package in EPEL and/or
> Fedora?  I don't actually use it, so you'll probably do a much better job than I
> at maintaining it.

Any/all would be fine.

Ok, here's a new request with that change, too:

Package Change Request
======================
Package Name: perl-PDL
New Branches: EL-5
Updated Fedora Owners: rnorwood, orion
Updated EPEL Owners: rnorwood, orion

cvs done.

ok, building for EL5

oops, looks like orion beat me to it.  All yours. :-)

Build succeeded.  Closing again.  Thanks all!

Package Change Request
======================
Package Name: perl-PDL
New Branches: 
Owners: 
InitialCC: perl-sig

Please add perl-sig user with watch* permissions only to all Fedora branches.

Done.