Bug 2262769

Summary:	Review Request: ghc-libBF - A binding to the libBF library
Product:	[Fedora] Fedora	Reporter:	Frank Dedden <frank>
Component:	Package Review	Assignee:	Jens Petersen <petersen>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	haskell-devel, package-review
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	petersen: fedora-review+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-07-08 16:58:00 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Frank Dedden 2024-02-05 11:40:42 UTC

Spec URL: https://fdedden.fedorapeople.org/ghc-libBF.spec
SRPM URL: https://fdedden.fedorapeople.org/ghc-libBF-0.6.7-1.fc40.src.rpm

Description:
LibBF is a C library for working with arbitray precision IEEE 754 floating
point numbers.

Fedora Account System Username: fdedden

Comment 1 Frank Dedden 2024-02-05 11:40:45 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=112968488

Comment 2 Jens Petersen 2024-05-28 14:54:04 UTC

The package complies with the packaging guidelines and installs.
Spec file is generated with cabal-rpm and LGTM.
License is MIT.

Package APPROVED

If you wish you could probably enable the testsuite for this package.

Comment 3 Fedora Admin user for bugzilla script actions 2024-07-01 12:52:20 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-libBF

Comment 4 Frank Dedden 2024-07-02 15:19:20 UTC

I have enabled the test-suite, and the package built successfully. It has been added to rawhide.

Comment 5 Frank Dedden 2024-07-02 15:37:15 UTC

(In reply to Frank Dedden from comment #4)
> I have enabled the test-suite, and the package built successfully. It has
> been added to rawhide.

This is not the case, it is currently still being build (for nearly a day).

My mistake of closing this review request, I posted it to the wrong one... Reopening this one.

Comment 6 Frank Dedden 2024-07-07 16:54:11 UTC

The stalling test for i686 was a known issue: https://github.com/GaloisInc/libBF-hs/issues/26.

I have bumped the version of the library to be 0.6.8 which contains a fix for this problem.

The build is now successful and should be picked up for inclusion soon.