Bug 226277
Summary: | Merge Review: perl-RPM-Specfile | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> | ||||
Component: | Package Review | Assignee: | Steven Pritchard <steve> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | robin.norwood | ||||
Target Milestone: | --- | Flags: | steve:
fedora-review+
|
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2009-02-05 09:26:12 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:37:44 UTC
Created attachment 150516 [details]
spec patch
- Fix find option order.
- Use fixperms macro instead of our own chmod incantation.
- Improve description.
- Add Archive::Tar, ExtUtils::MakeMaker, and URI::Escape build deps.
- Remove redundant YAML explicit dep.
- Package README.
My patch still applies fine... applied patch and built for f8! I think this needs a '+' fedora-review from you before closing. Apparently I missed two (really, really minor) things that rpmlint complains about: W: perl-RPM-Specfile macro-in-%changelog _libdir W: perl-RPM-Specfile mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 16) It looks like you can fix those with the following if you want: sed -i -e '100s/%/%%/;16s/\t/ /' perl-RPM-Specfile.spec I think those are minor enough to call this APPROVED though. fixed in 1.51-4 We can close this now, right? This package is needed in EPEL-{4,5} for perl-Satcon. I can maintain it for EPEL, if you don't want it. Hm false alarm. This package have branches for RHEL, but it wasn't included into comps. Ok, now we can close it because problem with EPEL/RHEL will be solved in different tickets. |