Bug 2262771

Summary:	Review Request: ghc-versions - Types and parsers for software version numbers
Product:	[Fedora] Fedora	Reporter:	Frank Dedden <frank>
Component:	Package Review	Assignee:	Jens Petersen <petersen>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	haskell-devel, package-review
Target Milestone:	---	Flags:	petersen: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://hackage.haskell.org/package/versions
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-07-02 15:22:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Frank Dedden 2024-02-05 11:54:58 UTC

Spec URL: https://fdedden.fedorapeople.org/ghc-versions.spec
SRPM URL: https://fdedden.fedorapeople.org/ghc-versions-6.0.3-1.fc40.src.rpm

Description:
A library for parsing and comparing software version numbers. We like to give
version numbers to our software in a myriad of ways. Some ways follow strict
guidelines for incrementing and comparison. Some follow conventional wisdom and
are generally self-consistent. Some are just plain asinine. This library
provides a means of parsing and comparing /any/ style of versioning, be it a
nice Semantic Version like this:

> 1.2.3-r1+git123

...or a monstrosity like this:

> 2:10.2+0.0093r3+1-1

Please switch to <http://semver.org Semantic Versioning> if you aren't
currently using it. It provides consistency in version incrementing and has the
best constraints on comparisons.

This library implements version '2.0.0' of the SemVer spec.

Fedora Account System Username: fdedden

Comment 1 Frank Dedden 2024-02-05 11:55:00 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=112969125

Comment 2 Fedora Review Service 2024-02-05 12:08:08 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6986379
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2262771-ghc-versions/fedora-rawhide-x86_64/06986379-ghc-versions/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Jens Petersen 2024-05-28 15:12:07 UTC

The package complies with the packaging guidelines and installs.
Spec file is generated with cabal-rpm and looks fine to me.
License is BSD3.

You can try turning on the testsuite.

Package APPROVED

Comment 4 Fedora Admin user for bugzilla script actions 2024-07-01 13:25:22 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-versions

Comment 5 Frank Dedden 2024-07-02 15:22:37 UTC

I have enabled the test-suite, and the package built successfully. It has been added to rawhide.