Bug 226283
| Summary: | Merge Review: perl-URI | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | perl-devel, ppisar, redhat-bugzilla, robin.norwood |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-30 08:37:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:38:28 UTC
1)perl as BR is not needed. mock build without it worked successfully.
remove redundant dependency on perl >= 1:5.6.1
2)drop "|| :" from %check
3) make test output skipped one test
t/urn-isbn.......skipped
all skipped: Needs the Business::ISBN module installed
I think you need to add that(Business::ISBN) perl module as BR
4)rpmlint complained ->
perl-URI.noarch: W: file-not-utf8 /usr/share/doc/perl-URI-1.35/Changes
The character encoding of this file is not UTF-8. Consider converting it
in the specfile for example using iconv(1).
==> Use iconv command
perl-URI.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance. Use either spaces or tabs for indentation, not both.
==> Use sed
perl-URI.src: W: strange-permission filter-requires-perl-URI.sh 0755
A file that you listed to include in your package has strange
permissions. Usually, a file should have 0644 permissions.
==> This can be Ignored.
1, 2, and 4) all fixed. 3) perl(Business::ISBN) is not available in Fedora yet - submitted review request here: https://bugzilla.redhat.com/show_bug.cgi?id=351761 The BR: perl(Business::ISBN) is commented out for now. New version is 1.35-4.fc9 I will wait for perl(Business::ISBN) then will review this. Can you update package with adding BR: perl(Business::ISBN)? updates please? Any updates? Sorry, meant to update this. Building perl-URI fails with the BR: perl(Business::ISBN) : t/urn-isbn.......Can't locate object method "country_code" via package "Business::ISBN10" at perl-URI/devel/URI-1.35/blib/lib/URI/urn/isbn.pm line 40. And I haven't looked into why yet. I'll take another look today. It clearly looked like bug in tests of perl-URI as perl(Business::ISBN) does not contain country_code. perl-Business-ISBN is new package so tests of perl-URI should be updated according to this package. I don't want to block review here waiting tests to be fixed. You better file bug against perl-URI. Otherwise packaging looks good. APPROVED. Package Change Request ====================== Package Name: perl-URI Branches: f15 f16 Owners: InitialCC: perl-sig Please add perl-sig user with watch* permissions only to all Fedora branches. Done. |