Bug 226286
| Summary: | Merge Review: perl-XML-LibXML-Common | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | robin.norwood |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-12 10:38:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:38:45 UTC
1)perl as BR is not needed. mock build without it worked successfully. remove redundant dependency on perl >= 2:5.8.0 2)drop "|| :" from %check 3)you may like to use disttag 4)you may like to use Source URL as http://www.cpan.org/authors/id/P/PH/PHISH/XML-LibXML-Common-%{version}.tar.gz 5)rpmlint only complained -> perl-XML-LibXML-Common.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 3) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. ==>Use "sed -i -e 's|\t| |g' perl-XML-LibXML-Common.spec" All of the above fixed in version perl-XML-LibXML-Common-0.13-10.fc9 Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 13b6d93f53375d15fd11922216249659 XML-LibXML-Common-0.13.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl 1..8 # Running under perl version 5.008008 for linux # Current time local: Fri Oct 26 00:20:39 2007 # Current time GMT: Fri Oct 26 04:20:39 2007 # Using Test.pm version 1.25 ok 1 ok 2 ok 3 ok 4 ok 5 ok 6 ok 7 ok 8 + Package perl-XML-LibXML-Common-0.13-10.fc8 -> Provides: Common.so perl(XML::LibXML::Common) = 0.13 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libm.so.6 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libxml2.so.2 libz.so.1 perl(:MODULE_COMPAT_5.8.8) perl(DynaLoader) perl(Exporter) perl(constant) perl(strict) perl(vars) rtld(GNU_HASH) APPROVED. You can CLOSE this review as reviewed package is already built in rawhide. Can we CLOSE this review if package is already built and in rawhide? |