Bug 2263035

Summary:	Review Request: kmidimon - Drumstick MIDI monitor
Product:	[Fedora] Fedora	Reporter:	Yaakov Selkowitz <yselkowi>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	ngompa13: fedora-review+
Hardware:	All
OS:	Linux
URL:	https://kmidimon.sourceforge.net
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-03-07 00:57:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yaakov Selkowitz 2024-02-06 17:19:37 UTC

Spec URL: https://yselkowitz.fedorapeople.org/kmidimon.spec
SRPM URL: https://yselkowitz.fedorapeople.org/kmidimon-1.4.0-1.fc40.src.rpm
Description: Drumstick MIDI Monitor monitors events coming from MIDI external ports or applications via the ALSA sequencer, and from SMF (Standard MIDI files) or WRK (Cakewalk/Sonar) files. It is especially useful if you want to debug MIDI software or your MIDI setup. It features a nice graphical user interface, customizable event filters and sequencer parameters, support for MIDI and ALSA messages, and saving the recorded event list to a SMF or text file.
Fedora Account System Username: yselkowitz

Comment 1 Fedora Review Service 2024-02-06 17:30:27 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6994649
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263035-kmidimon/fedora-rawhide-x86_64/06994649-kmidimon/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2024-02-26 20:02:35 UTC

Review notes:

* Packaging follows Fedora packaging guidelines
* Package builds and installs
* Package licensing is correctly recorded
* No serious issues from rpmlint

PACKAGE APPROVED.

Extra notes:

> BuildRequires:  cmake(drumstick-alsa) >= 2.9
> # transitive dependency of drumstick-alsa
> BuildRequires:  alsa-lib-devel >= 1.0

This is not required because "cmake(drumstick-alsa)" already requires "alsa-lib-devel".

Comment 3 Fedora Admin user for bugzilla script actions 2024-02-26 21:36:51 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/kmidimon

Comment 4 Fedora Update System 2024-02-27 00:57:27 UTC

FEDORA-2024-b32c7ee674 (kmidimon-1.3.1-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b32c7ee674

Comment 5 Fedora Update System 2024-02-28 01:03:25 UTC

FEDORA-2024-b32c7ee674 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b32c7ee674 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b32c7ee674

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2024-03-07 00:57:04 UTC

FEDORA-2024-b32c7ee674 (kmidimon-1.3.1-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.