Bug 226347
| Summary: | Merge Review: python-urlgrabber | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Bryan Kearney <bkearney> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | katzj |
| Target Milestone: | --- | Flags: | jbowes:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-08-27 15:28:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:46:54 UTC
I'll review this. Notes:
X package meets packaging guidelines:
%install should being by removing the buildroot
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
X license field matches the actual license.
* license is open source-compatible.
* License text included in package.
* source files match upstream
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock.
X rpmlint has 3 warnings:
W: python-urlgrabber invalid-license LGPL
W: python-urlgrabber redundant-prefix-tag
W: python-urlgrabber setup-not-quiet
* final provides and requires are sane:
urlgrabber = 3.0.0-1.fc7
python-urlgrabber = 3.0.0-1.fc7
======
/usr/bin/python
python(abi) = 2.5
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present
* scriptlets OK
* code, not content.
* upstream includes no docs.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
The license must be updated and %install must be fixed as well. The other two
rpmlint warnings should be fixed as well. Source0 should also be a url. I'll
approve the package when these are fixed.
Three nice to haves:
* use one of the three standard buildroot definitions
* use the 4 arg form of defattr
* use the single '%{python_sitelib}/urlgrabber' in files rather than the two
%dir and /* lines
All fixed for -2. (In reply to comment #3) > All fixed for -2. Great. Approved. |