Bug 226356
| Summary: | Merge Review: rcs | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> | ||||||||
| Component: | Package Review | Assignee: | Ville Skyttä <ville.skytta> | ||||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | jmoskovc, pknirsch | ||||||||
| Target Milestone: | --- | Flags: | ville.skytta:
fedora-review+
|
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2010-01-11 22:35:05 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:48:15 UTC
1) COPYING is not included. 2) automake does not appear to be required, autoconf is enough. 3) Shipping some docs as PDF would be more useful than troff sources. 4) I don't quite understand the idea behind the "stupidrcs" patch, it appears to be using hardwired values for things I suppose ./configure should be detecting. Could you explain it? Will attach fix for items 1-3. Created attachment 321729 [details]
Fix for items 1-3
Thanks for the patch. I really don't know now why we need the "stupidrcs" patch I would have to look into the autoconf/configure magic - but it seems it doesn't compile without it... Updated srpm and spec file: SRPM: http://people.fedoraproject.org/~jmoskovc/rcs-5.7-34.fc10.src.rpm SPEC: http://people.fedoraproject.org/~jmoskovc/rcs.spec I'm not quite comfortable with approving this package without at least an explanation why the patch exists apart from that it makes the package compile; it looks and feels "wrong" to me. Please do look into it and report when you find the time and I'll have another look. No rush. Created attachment 349004 [details]
Fix remaining issues
Here's a patch for the remaining issues and a few other improvements. Let me know if you'd like me to apply and build this for devel.
Patch0 should be downloaded from the URL in the patched specfile, and rcs-5.7-stupidrcs.patch can now be removed also from CVS. Updated DESTDIR patch follows in a jiffy.
Created attachment 349005 [details]
Updated DESTDIR patch
I finally got to this, applied all of your proposed changes and it's built as rcs-5.7-36 in rawhide. Thank you, Jirka |