| Summary: | Merge Review: rdate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Phil Knirsch <pknirsch> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | pknirsch, rvokal |
| Target Milestone: | --- | Flags: | roozbeh:
fedora-review-
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-05-29 13:26:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:48:27 UTC
Random first notes:
* Remove the dot at the end of Summary line.
* It seems that there is no upstream. No URL is given, and the Source address
doesn't work either. So I can't check that this is the same as the upstream
source. (BLOCKER)
* Change BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Use the option %{?_smp_mflags} for make.
* Don't use %makeinstall, if possible. See
http://fedoraproject.org/wiki/Packaging/Guidelines#MakeInstall
* Use %defattr(-,root,root,-) instead of %defattr(-,root,root)
* Consider using %{?dist} in Release tag.
* The binary file 'rdate' is installed with permission 555 in the Makefile. It
should be 755. This can be fixed either by patching the Makefile or by
explicitly changing the permission in the %install or %files section. (BLOCKER)
* Remove the dot at the end of Summary line.
Fixed
* It seems that there is no upstream. No URL is given, and the Source address
doesn't work either. So I can't check that this is the same as the upstream
source. (BLOCKER)
There is no real upstream anymore except the tarball from sopwith (Elliot Lee)
* Change BuildRoot to %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Fixed
* Use the option %{?_smp_mflags} for make.
Fixed
* Don't use %makeinstall, if possible. See
http://fedoraproject.org/wiki/Packaging/Guidelines#MakeInstall
Fixed
* Use %defattr(-,root,root,-) instead of %defattr(-,root,root)
Fixed
* Consider using %{?dist} in Release tag.
Fixed
* The binary file 'rdate' is installed with permission 555 in the Makefile. It
should be 755. This can be fixed either by patching the Makefile or by
explicitly changing the permission in the %install or %files section. (BLOCKER)
Fixed
|