Bug 226361
| Summary: | Merge Review: readline | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mlichvar, redhat-bugzilla |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-11-13 05:07:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 20:48:56 UTC
like to review this 1)rpmlint complained on RPM readline-devel.i386: W: file-not-utf8 /usr/share/doc/readline-devel-5.2/rl-fgets.c The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1). 2) defattr usage should be defattr(-,root,root,-) 3) Good to follow Texinfo scriptlet given at http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-47896da5fb2662d75deefeb9ba75145a398515db 4) Do we need static package here? (In reply to comment #2) > 1)rpmlint complained on RPM > readline-devel.i386: W: file-not-utf8 /usr/share/doc/readline-devel-5.2/rl-fgets.c > The character encoding of this file is not UTF-8. Consider converting it > in the specfile for example using iconv(1). Ok. > 2) defattr usage should be defattr(-,root,root,-) Ok. Fixed with 1) in readline-5.2-8.fc9. > 3) Good to follow Texinfo scriptlet given at > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-47896da5fb2662d75deefeb9ba75145a398515db With more commands in the script it's IMHO nicer to put : at the end of the script. It's mentioned in the ScriptletSnippets page. > 4) Do we need static package here? lvm2 buildrequires readline-static. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. e39331f32ad14009b9ff49cc10c5e751 readline-5.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. - static libraries are present. + no .pc file present. + -devel,-static subpackages exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + package readline-5.2-8.fc8 -> Provides: libhistory.so.5 libreadline.so.5 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libhistory.so.5 libreadline.so.5 libtinfo.so.5 rtld(GNU_HASH) + package readline-5.2-8.fc8 -> Requires: libhistory.so.5 libreadline.so.5 ncurses-devel readline = 5.2-8.fc8 + package readline-static-5.2-8.fc8 -> Requires: readline-devel = 5.2-8.fc8 + Not a GUI app. APPROVED. oops ldconfig and install-info scriptlets are used. |