Bug 2263714
| Summary: | Review Request: rust-names - Random name generator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | carmelo.sarta.main, decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/names | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-02-19 19:35:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2024-02-11 08:11:37 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=113333538 *** Bug 2089042 has been marked as a duplicate of this bug. *** This was generated with the following rust2rpm.toml: [package] summary = "Random name generator" Copr build: https://copr.fedorainfracloud.org/coprs/build/7007683 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2263714-rust-names/fedora-rawhide-x86_64/07007683-rust-names/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package looks good, just one question: Do you actually want to build + ship /usr/bin/names? The package would be simpler without it, and it would probably build a lot faster: - stop building the binary (by adding "autobins = false" setting under the [package] table) - remove the "application" feature from the features table (or the entire [features] table) - drop the "clap" dependency that is unused if you don't build the CLI Yeah, I think the binary is useful so I'd rather ship it. Ok, that's fine then. Note that the License tag in the binary subpackage is wrong, it should be: License: MIT AND (Apache-2.0 OR MIT) AND (Unlicense OR MIT) not: License: (Apache-2.0 OR MIT) AND MIT AND (MIT OR Apache-2.0) === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === If you have time, it would be great if you could review one of my pending packages in return. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-names FEDORA-2024-84b1c1a7c6 (rust-names-0.14.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-84b1c1a7c6 FEDORA-2024-84b1c1a7c6 (rust-names-0.14.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-f42cfedcbc (rust-names-0.14.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f42cfedcbc FEDORA-2024-f42cfedcbc (rust-names-0.14.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-7902ac15f4 (rust-names-0.14.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7902ac15f4 FEDORA-2024-130f83bf29 (rust-names-0.14.0-1.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-130f83bf29 FEDORA-2024-7902ac15f4 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7902ac15f4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7902ac15f4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-130f83bf29 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-130f83bf29 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-130f83bf29 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-7902ac15f4 (rust-names-0.14.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-130f83bf29 (rust-names-0.14.0-1.fc38) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |