Bug 226414
Summary: | Merge Review: sg3_utils | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
Component: | Package Review | Assignee: | Denis Leroy <denis> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | pknirsch |
Target Milestone: | --- | Flags: | denis:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-03-28 10:23:22 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Nobody's working on this, feel free to take it
2007-01-31 20:58:45 UTC
sg3_utils needs some love. Spec is not fedora compliant (static libs, .la libs). It also could use an update to 1.25 which uses automake and will make the spec file simpler. 1.25 also introduces the very useful 'sg_raw' utility. Will take care of it next week. Read ya, Phil Ok, did some final cleanups to the specfile and removed the static libraries. The remaining rpmlint warnings are either not fixable or plainly wrong for this package (libs package doesn't contain any documentation and sg3_utils-devel only needs the sg3_utils-libs package to work properly). Building sg3_utils-1.25-3 in rawhide as i write this, so should land in the next couple of days in the tree. Let me know if there is anything else you see that should be changed. Thanks, Read ya, Phil Looking good. couple of minor non-blocking nitpicks - is the "Provides: sg_utils' still useful ? - instead of removing the *.a files, simply configure with '--disable-static' (you still need to keep the removal of *.la files though). This review is APPROVED. I just figured i'd keep the Provides in, but i checked today once more and we never actually shipped sg_utils in Fedora or Red Hat, so i'll just drop it. And good point about the 2nd thing, will add that in the new build as well. Thanks Denis! Read ya, Phil |