Bug 2264283

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=113511158

*** Bug 2030862 has been marked as a duplicate of this bug. ***

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7018177
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264283-cros-guest-tools/fedora-rawhide-x86_64/07018177-cros-guest-tools/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Hi Sergio.
This package currently installs files in /etc/skel/.config/pulse but the directory itself and many others are not owned by the package.

```
[X]: Package requires other packages for directories it uses.
     Note: No known owner of /etc/skel/.config/pulse
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/ansible,
     /etc/skel/.config/pulse, /var/lib/polkit-1/localauthority,
     /usr/share/ansible/plugins/callback, /etc/skel/.config,
     /var/lib/polkit-1, /etc/gtk-2.0,
     /var/lib/polkit-1/localauthority/10-vendor.d,
     /usr/share/ansible/plugins
```

Can the use of /etc/skel/.config be changed to something more visible, like /etc/skell/cros/.config? The package could also then own these directories.

Additionally,
- Note: warning: File listed twice: /etc/gtk-3.0/settings.ini

rpm -qf  /usr/share/ansible/
ansible-core-2.16.10-1.fc39.noarch

rpm -qf /var/lib/polkit-1/localauthority/
polkit-pkla-compat-0.1-26.fc39.x86_64

so the vast of directory are already owned .

about change directory , I think is general the use of /etc/skel/.config , also instructions and is meant to copy to $HOME/.config 

I fixed the File listed twice

Let me know what I could do 

thanks,

Spec URL: https://sergiomb.fedorapeople.org/cros-guest-tools/cros-guest-tools.spec
SRPM URL: https://sergiomb.fedorapeople.org/cros-guest-tools/cros-guest-tools-126-1.fc42.src.rpm

Created attachment 2047475 [details]
The .spec file difference from Copr build 7018177 to 8032570

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8032570
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264283-cros-guest-tools/fedora-rawhide-x86_64/08032570-cros-guest-tools/fedora-review/review.txt

Found issues:

- Not a valid SPDX expression 'BSD'. It seems that you are using the old Fedora license abbreviations. Try `license-fedora2spdx' for converting it to SPDX.
  Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/cros-guest-tools
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names
- Systemd service file(s) in cros-host-fonts
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets
- Systemd user unit service file(s) in cros-garcon, cros-notificationd, cros-sommelier, cros-sommelier-config
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

License fixed to BSD-3-Clause

[fedora-review-service-build]

Created attachment 2047535 [details]
The .spec file difference from Copr build 8032570 to 8033816

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8033816
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264283-cros-guest-tools/fedora-rawhide-x86_64/08033816-cros-guest-tools/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/cros-guest-tools
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names
- Systemd service file(s) in cros-host-fonts
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets
- Systemd user unit service file(s) in cros-garcon, cros-notificationd, cros-sommelier, cros-sommelier-config
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_user_units

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Overall LGTM.
APPROVED

Please go to https://pagure.io/packager-sponsors/issues to get a sponsor. I am unfortunately unable to sponsor you, but I'm sure you'll be able to find somebody willing.
Thanks for your contribution!

(In reply to Leo Puvilland from comment #14)
> Please go to https://pagure.io/packager-sponsors/issues to get a sponsor. I
> am unfortunately unable to sponsor you, but I'm sure you'll be able to find
> somebody willing.
> Thanks for your contribution!

thank you , I'm a proven packager the packages are already build on koji expect fo F41 , because [1] 

this is unretire process [2] that is why (I guess) I didn't provide my fas (sergiomb) 

Best regards,


[1] 
https://pagure.io/releng/issue/12343#comment-933570

[2]
https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/#claiming

FEDORA-2024-0e6d75e940 (cros-guest-tools-126-2.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0e6d75e940

FEDORA-2024-d8998d154b (cros-guest-tools-126-2.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-d8998d154b

FEDORA-EPEL-2024-13cac0d3e8 (cros-guest-tools-126-2.el8) has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-13cac0d3e8

Apologies, did not see that. I must have confused this bug with another that had FE-NEEDSPONSOR as blocking.
Thank you!

FEDORA-EPEL-2024-26103c16c7 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-26103c16c7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-26b2c36511 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-26b2c36511`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-26b2c36511

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-58e1fba480 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-58e1fba480`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-58e1fba480

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-EPEL-2024-26103c16c7 (cros-guest-tools-126-3.el8) has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-58e1fba480 (cros-guest-tools-126-3.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-26b2c36511 (cros-guest-tools-126-3.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.