Bug 2264457

Summary: Review Request: sudo-rs - Memory safe implementation of sudo and su
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://github.com/memorysafety/sudo-rs
Whiteboard:
Fixed In Version: sudo-rs-0.2.2-1.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-02-24 17:46:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Fabio Valentini 2024-02-15 18:42:50 UTC
Spec URL: https://decathorpe.fedorapeople.org/sudo-rs.spec
SRPM URL: https://decathorpe.fedorapeople.org/sudo-rs-0.2.2-1.fc39.src.rpm

Description:
A memory safe implementation of sudo and su.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-02-15 18:42:53 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=113552478

Comment 2 Fedora Review Service 2024-02-15 18:50:14 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7020501
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264457-sudo-rs/fedora-rawhide-x86_64/07020501-sudo-rs/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2024-02-23 17:33:17 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate):

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fabio Valentini 2024-02-24 16:34:28 UTC
Thank you for the review!

There's now a fix upstream for the issue on s390x, I'll include that as well and build the package for all architectures.

Comment 5 Fedora Admin user for bugzilla script actions 2024-02-24 16:36:16 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/sudo-rs

Comment 6 Fabio Valentini 2024-02-24 17:46:49 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a036d72438