Bug 226447
| Summary: | Merge Review: sysfsutils | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> | ||||
| Component: | Package Review | Assignee: | Todd Zullinger <tmz> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | jarod, kevin, redhat-bugzilla | ||||
| Target Milestone: | --- | Flags: | tmz:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-02-25 22:25:58 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 426387 | ||||||
| Attachments: |
|
||||||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 21:03:50 UTC
Should actually be assigned to nobody until someone picks it up for review, only needs to be assigned over to me once a reviewer says there's something that needs my attention. Jarod, here's a review. Things look mostly sane. The few minor issues are
noted below. I'll attach a patch that makes these changes. Feel free to use
some or all of it, with or without attribution. ;)
* source files match upstream:
b3cb316c652b09ec66f93f4ea98a93a7a1001678 sysfsutils-2.1.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
X license field matches the actual license.
The main package license should be GPLv2
(cmd/systool.c specifies v2 and has no "or any later version clause")
The libsysfs subpackage should be LGPLv2+
* license is open source-compatible.
* latest version is being packaged.
* BuildRequires are proper (none are needed).
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (fedora-devel-x86_64,).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent. (not quite, but these warnings should be okay to ignore):
sysfsutils.x86_64: W: incoherent-version-in-changelog 2.1.0-2 2.1.0-1.fc9
libsysfs-devel.x86_64: W: no-documentation
* final provides and requires are sane
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
X scriptlets are properly run for libs
ldconfig needs to be run for the libsysfs subpackage
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
Created attachment 291411 [details]
patch to fix minor issues for merge review
D'oh. This got lost in the shuffle... Just made these changes (more or less) to rawhide, building now. Todd: Did you want to mark this with fedora-review + ? Jarod: You shouldn't usually close until it's been approved... ;) Yep, I wanted to look back over it before I added the fedora-review +, since it was a month ago that I did the review and my memory needs frequent refreshing. It looks like everything is good. Thanks Jarod (and Kevin for poking :). Whoops, sorry, my mistake... Got close-happy plowing through bugs yesterday... :) |