Bug 2264482

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7021068
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264482-rust-backoff/fedora-rawhide-x86_64/07021068-rust-backoff/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

The package builds, but not all built packages install:

Problem: conflicting requests
  - nothing provides (crate(getrandom/js) >= 0.2.0 with crate(getrandom/js) < 0.3.0~) needed by rust-backoff+wasm-bindgen-devel-0.4.0-1.fc41.noarch
  - nothing provides (crate(instant/wasm-bindgen) >= 0.1.0 with crate(instant/wasm-bindgen) < 0.2.0~) needed by rust-backoff+wasm-bindgen-devel-0.4.0-1.fc41.noarch

I recommend running local mock builds with "--postinstall" to catch this sort of errors.

You might need to patch Cargo.toml (with "rust2rpm -p") to remove this line:

> wasm-bindgen = ["instant/wasm-bindgen", "getrandom/js"]

This is for WebAssembly / WASM only, which is a target we don't support in package builds - so there are some missing dependencies for it.

Thank you Fabio.

Spec URL: https://alciregi.fedorapeople.org/rustrpm/rust-backoff.spec
SRPM URL: https://alciregi.fedorapeople.org/rustrpm/rust-backoff-0.4.0-1.fc39.src.rpm

Created attachment 2017282 [details]
The .spec file difference from Copr build 7021068 to 7027749

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7027749
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264482-rust-backoff/fedora-rawhide-x86_64/07027749-rust-backoff/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Sorry for the delay here, the notifications your your update got lost in my inbox.

> # https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
> ExcludeArch:    %{ix86}

Please don't do this for library packages. It creates unnecessary headaches.
You're free to exclude i686 for applications, but for libraries, keeping i686 for Rust crates is preferable for now.

Other than that, package looks OK.

Ok. Thank you

Spec URL: https://alciregi.fedorapeople.org/rustrpm/rust-backoff.spec
SRPM URL: https://alciregi.fedorapeople.org/rustrpm/rust-backoff-0.4.0-1.fc39.src.rpm

Without ExcludeArch

Created attachment 2019342 [details]
The .spec file difference from Copr build 7027749 to 7087969

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7087969
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264482-rust-backoff/fedora-rawhide-x86_64/07087969-rust-backoff/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thank you, looks good to me now.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (tests disabled with explanation)
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-backoff

FEDORA-2024-f67698a162 (rust-backoff-0.4.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f67698a162

FEDORA-2024-f67698a162 (rust-backoff-0.4.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-1ee6423f7c (rust-backoff-0.4.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1ee6423f7c

FEDORA-2024-1ee6423f7c has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1ee6423f7c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1ee6423f7c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-1ee6423f7c (rust-backoff-0.4.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.