Bug 2264552
| Summary: | Review Request: plasma-welcome-fedora - Fedora-related customizations for Plasma-welcome | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Cossette <farchord> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| URL: | https://pagure.io/fedora-kde/plasma-welcome-fedora | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-07-22 17:41:24 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Steve Cossette
2024-02-16 14:26:33 UTC
The contents of the files in the package can be found here: https://pagure.io/fedora-kde/plasma-welcome-fedora/ Taking this review. Copr build: https://copr.fedorainfracloud.org/coprs/build/7027754 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264552-plasma-welcome-fedora/fedora-rawhide-x86_64/07027754-plasma-welcome-fedora/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Initial spec review: > Source0: intro-customization.desktop > Source1: 01-EnableExtraRepos.qml Instead, we should do the following: > URL: https://pagure.io/fedora-kde/plasma-welcome-fedora > Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz And release this as 6.0.0 > install -Dpm644 %{_sourcedir}/intro-customization.desktop %{buildroot}%{_kf6_datadir}/plasma/plasma-welcome/intro-customization.desktop For now, let's not ship this, because we don't know yet how to handle the branding configuration stuff yet. I also noticed a lack of license files being captured. This also needs the following:
> Requires: fedora-third-party
> Requires: (fedora-workstation-repositories unless rpm-ostree)
> Requires: fedora-flathub-remote
Spec URL: https://farchord.fedorapeople.org/reviews/plasma-welcome-fedora/plasma-welcome-fedora.spec SRPM URL: https://farchord.fedorapeople.org/reviews/plasma-welcome-fedora/plasma-welcome-fedora-6.1.0-1.fc40.src.rpm Fixed a slew of things. One suggestion could not be implemented as it's not accepted by rpm. > %global debug_package %{nil}
Drop this and instead add "BuildArch: noarch" after Source0.
Created attachment 2038762 [details]
The .spec file difference from Copr build 7027754 to 7700366
Copr build: https://copr.fedorainfracloud.org/coprs/build/7700366 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264552-plasma-welcome-fedora/fedora-rawhide-x86_64/07700366-plasma-welcome-fedora/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://farchord.fedorapeople.org/reviews/plasma-welcome-fedora/plasma-welcome-fedora.spec SRPM URL: https://farchord.fedorapeople.org/reviews/plasma-welcome-fedora/plasma-welcome-fedora-6.1.0-1.fc40.src.rpm Added buildarch Created attachment 2038771 [details]
The .spec file difference from Copr build 7700366 to 7700412
Copr build: https://copr.fedorainfracloud.org/coprs/build/7700412 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2264552-plasma-welcome-fedora/fedora-rawhide-x86_64/07700412-plasma-welcome-fedora/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. At this point, everything looks good.
> Requires: (fedora-workstation-repositories unless rpm-ostree)
This should just be "Requires: fedora-workstation-repositories", but this can be resolved when importing.
PACKAGE APPROVED.
Thank you for the review, Neal The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-welcome-fedora |