Bug 226518
| Summary: | Merge Review: usbutils | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> | ||||
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | jmoskovc, twoerner | ||||
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2008-02-15 09:10:27 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 21:13:58 UTC
1)rpmlint on current rawhide package gave me usbutils.src: E: non-utf8-spec-file /tmp/usbutils-0.73-1.src.rpm.10603/usbutils.spec ==> use iconv command to convert spec file to UTF8 format iconv -f ISO-8859-1 -t UTF-8 usbutils.spec >usbutils.spec.new mv usbutils.spec.new usbutils.spec usbutils.src: W: summary-ended-with-dot Linux USB utilities. ==> remove dot from summary usbutils.src: E: tag-not-utf8 %changelog usbutils.src: W: invalid-license GPL ==> use GPLv2+ 2) You can add dist tag if you want http://fedoraproject.org/wiki/Packaging/DistTag 3)you can use parallel make as make %{?_smp_mflags} 4)Remove generic INSTALL from %doc 5) Do not use %makeinstall Created attachment 294647 [details]
spec cleanup
You can use attached patch to solve packaging issues.
Add changelog and bump release.
Hi, thanks for the patch, I've commited the proposed changes to cvs. Thanks for quick work.
1) But, I think patch did not solved following issues
usbutils.src: E: non-utf8-spec-file
/tmp/usbutils-0.73-2.fc9.src.rpm.9287/usbutils.spec
usbutils.src: E: tag-not-utf8 %changelog
solution==>
iconv -f ISO-8859-1 -t UTF-8 usbutils.spec >usbutils.spec.new
mv usbutils.spec.new usbutils.spec
2) remove following line from SPEC
cp /usr/share/libtool/config.{sub,guess} .
as you already have BR: libtool
I got successful scratch build with above changes at
http://koji.fedoraproject.org/koji/taskinfo?taskID=418904
3)Source URL should be
http://downloads.sourceforge.net/linux-usb/%{name}-{version}.tar.gz
4) change make install line in SPEC to
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
==> This will preserve timestamps.
5) Is following conflict line in SPEC for this package still needed?
Conflicts: hotplug < 3:2002_01_14-2
==> I saw no cvs module for hotplug in Fedora.
6)Also, Can you build this package?
Spec file fixed and converted. I'm not sure about hotplug, you can still install it from other repository, so even if it's not in official Fedora repo the conflict still exists.. Just finished the scratch build: http://koji.fedoraproject.org/koji/taskinfo? taskID=419085 looks Ok to me. I will wait for build in devel then will Approve this review. ping? Hi, build is complete: http://koji.fedoraproject.org/koji/buildinfo?buildID=36377 (In reply to comment #9) > Hi, build is complete: > http://koji.fedoraproject.org/koji/buildinfo?buildID=36377 Thanks for this build. APPROVED. |