Bug 226533
| Summary: | Merge Review: vsftpd | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Maros Barabas <mbarabas> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mbarabas, redhat-bugzilla |
| Target Milestone: | --- | Flags: | jpmahowald:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-04-04 13:14:28 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 21:16:08 UTC
Good:
+ License GPL
+ Follows naming guidelines
+ URL to source
+ %clean section
+ use of %doc macro
Fix these and it's approved:
- Use %{_var}, %{_sysconfdir}, and %{_sbindir} macros for %files and %install
- Change Prereq to Requires. Also use Requires (post) and Requires (preun) style
for chkconfig and service requirements.
- use preferred BuildRoot of
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Also drop this stuff, unneeded:
- "[ "$RPM_BUILD_ROOT" != "/" ] && " in %clean
- Requires: openssl, pam, libcap
- usermod requirement, not used (commented out).
|