Bug 226543
| Summary: | Merge Review: wordtrans | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nobody's working on this, feel free to take it <nobody> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | than |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-06-20 14:34:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Nobody's working on this, feel free to take it
2007-01-31 21:16:50 UTC
1. SHOULD: s/BuildPreReq:/BuildRequires:/ [rdieter1@sting devel]$ rpmlint \ fedora/core/7/i386/os/Fedora/RPMS/wordtrans-*.rpm E: wordtrans invalid-version 1.1pre13 E: wordtrans obsolete-not-provided wordtrans-qt E: wordtrans no-binary W: wordtrans file-not-utf8 /usr/share/man/es/man1/wordtrans.1.gz W: wordtrans file-not-utf8 /usr/share/doc/wordtrans-doc/ChangeLog.gz W: wordtrans file-not-utf8 /usr/share/man/man1/wordtrans.1.gz W: wordtrans file-not-utf8 /usr/share/doc/wordtrans-data/ChangeLog.gz E: wordtrans-kde invalid-version 1.1pre13 W: wordtrans-kde dangling-relative-symlink /usr/share/doc/wordtrans-kde/INSTALAR-NODEBIAN ../wordtrans-data/INSTALAR-NODEBIAN W: wordtrans-kde dangling-relative-symlink /usr/share/doc/wordtrans-kde/welcome_es.html ../wordtrans-data/welcome_es.html W: wordtrans-kde dangling-relative-symlink /usr/share/locale/fr/LC_MESSAGES/kwordtrans.mo wordtrans.mo W: wordtrans-kde dangling-relative-symlink /usr/share/doc/HTML/en/kwordtrans ../../wordtrans-doc/html.en W: wordtrans-kde dangling-relative-symlink /usr/share/locale/es/LC_MESSAGES/kwordtrans.mo wordtrans.mo W: wordtrans-kde dangling-relative-symlink /usr/share/doc/HTML/es/kwordtrans ../../wordtrans-doc/html.es W: wordtrans-kde dangling-relative-symlink /usr/share/doc/wordtrans-kde/welcome_en.html ../wordtrans-data/welcome_en.html W: wordtrans-kde dangling-relative-symlink /usr/share/doc/wordtrans-kde/INSTALAR ../wordtrans-data/INSTALAR W: wordtrans-kde dangling-relative-symlink /usr/share/doc/wordtrans-kde/ChangeLog.gz ../wordtrans-data/ChangeLog.gz W: wordtrans-kde dangling-relative-symlink /usr/share/doc/HTML/fr/kwordtrans ../../wordtrans-doc/html.fr W: wordtrans-kde dangling-relative-symlink /usr/share/doc/wordtrans-kde/TODO ../wordtrans-data/TODO W: wordtrans-kde dangling-relative-symlink /usr/share/doc/wordtrans-kde/INSTALL ../wordtrans-data/INSTALL W: wordtrans-kde dangling-relative-symlink /usr/share/doc/wordtrans-kde/README ../wordtrans-data/README W: wordtrans-kde dangling-relative-symlink /usr/share/doc/wordtrans-kde/INSTALL-NODEBIAN ../wordtrans-data/INSTALL-NODEBIAN W: wordtrans-kde dangling-relative-symlink /usr/share/doc/wordtrans-kde/LEEME ../wordtrans-data/LEEME E: wordtrans-web invalid-version 1.1pre13 W: wordtrans-web no-documentation 2. Version: 1.1pre13 doesn't follow Naming/Versioning Guidelines, but fixing it now may require an Epoch, which could be considered as-bad/worse. I'll punt on that for now. 3. imo, the use of cat inside of specfile SHOULD be replaced by SourceX: in sources or cvs. 4. MUST use a preferred BuildRoot, http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 OK, discussed on #fedora-devel, regarding Versioning.
2. MUST introduce Epoch to fix Versioning mess.
Epoch: 1
Version: 1.1
and (initially)
Release: 0.1.pre13%{?dist}
5. SHOULD address remaining "file-not-utf8" warnings from rpmlint.
I don't see anything else obvious, so address MUST items, and I'll APPROVE this.
i have fixed 1,2,3,4. Please take a look at wordtrans-1.1-0.1.pre13.fc7 built in rawhide. Thanks can you please approve it? Looks good, APPROVED. |