Bug 2265482

Summary: python-wsaccel fails to build with Python 3.13: wsaccel/utf8validator.c:28141:23: error: too few arguments to function ‘_PyLong_AsByteArray’
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: python-wsaccelAssignee: Orphan Owner <extras-orphan>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: fti-bugs, jujens, ksurma, mhroncok
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-08-23 12:58:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2260875, 2260877, 2300529, 2244836    

Description Karolina Surma 2024-02-22 09:55:04 UTC
python-wsaccel fails to build with Python 3.13.0a4.

wsaccel/utf8validator.c: In function ‘__Pyx_PyInt_As_int’:
wsaccel/utf8validator.c:28141:23: error: too few arguments to function ‘_PyLong_AsByteArray’
28141 |                 ret = _PyLong_AsByteArray((PyLongObject *)v,
      |                       ^~~~~~~~~~~~~~~~~~~
wsaccel/utf8validator.c: In function ‘__Pyx_PyInt_As_long’:
wsaccel/utf8validator.c:28414:23: error: too few arguments to function ‘_PyLong_AsByteArray’
28414 |                 ret = _PyLong_AsByteArray((PyLongObject *)v,
      |                       ^~~~~~~~~~~~~~~~~~~

wsaccel/utf8validator.c: In function ‘__Pyx_PyInt_As_char’:
wsaccel/utf8validator.c:28811:23: error: too few arguments to function ‘_PyLong_AsByteArray’
28811 |                 ret = _PyLong_AsByteArray((PyLongObject *)v,
      |                       ^~~~~~~~~~~~~~~~~~~
/usr/include/python3.13/cpython/longobject.h:85:17: note: declared here
   85 | PyAPI_FUNC(int) _PyLong_AsByteArray(PyLongObject* v,
      |                 ^~~~~~~~~~~~~~~~~~~

This function has been removed from Python 3.13.
The detailed list of the removed private C API functions can be found here:
https://github.com/python/cpython/issues/106320

It looks like this package ships pregenerated Cython files. Per Python packaging policy:
"Tightening the general Fedora policy, packages MUST NOT use files pre-generated by Cython. These MUST be deleted in %prep and regenerated during the build.
As an exception, these sources MAY be used temporarily to prevent build time circular dependencies by following the bootstrapping guidelines."
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_using_cython


https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/07046963-python-wsaccel/

For all our attempts to build python-wsaccel with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-wsaccel/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karolina Surma 2024-06-12 15:10:38 UTC
*** Bug 2291975 has been marked as a duplicate of this bug. ***

Comment 2 Julien Enselme 2024-06-15 16:14:24 UTC
Reported upstream: https://github.com/methane/wsaccel/issues/32

Comment 3 Fedora Fails To Install 2024-06-19 19:58:56 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 4 Fedora Fails To Install 2024-07-13 08:00:48 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 4+ weeks.
This is the second reminder (step 4) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 5 Julien Enselme 2024-07-19 08:22:55 UTC
I reported the problem awhile back upstream: https://github.com/methane/wsaccel/issues/32 No news yet. I’ll orphan the package if it becomes too blocking (I don’t think the package is used any more).

Comment 6 Fedora Fails To Install 2024-08-13 00:02:16 UTC
This package has been orphaned.

You can pick it up at https://src.fedoraproject.org/rpms/python-wsaccel by clicking button "Take". If nobody picks it up, it will be retired and removed from a distribution.

Comment 7 Fedora Admin user for bugzilla script actions 2024-08-22 18:45:22 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 8 Miro Hrončok 2024-08-23 12:58:33 UTC
Automation has figured out the package is retired in rawhide.

If you like it to be unretired, please open a ticket at https://pagure.io/releng/new_issue?template=package_unretirement