Bug 2265552

https://koji.fedoraproject.org/koji/taskinfo?taskID=113890263

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7050219
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2265552-pandoc-cli/fedora-rawhide-x86_64/07050219-pandoc-cli/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

This replaces the pandoc-cli currently bundled awkwardly in the pandoc package (should have submitted earlier).

The automatic review seemed not to generate but I can make a few comment on the local rpmlint:

pandoc-cli.x86_64: W: no-manual-page-for-binary pandoc
pandoc-cli.x86_64: W: no-manual-page-for-binary pandoc-lua

The manpage is still currently provided by the main pandoc package,
but this will change in newer versions: currently it is difficult
to build the newer versions bundled - so I want to get this new package
added to Fedora before updating pandoc to version.

See https://hackage.haskell.org/package/pandoc-cli-0.1.1.1
where one can see that newer versions of pandoc-cli are locked to specific pandoc versions,
starting with pandoc 3.1.10. So once updated the Provides will be sanitized.

rpmlint:
> pandoc-cli.x86_64: W: position-independent-executable-suggested /usr/bin/pandoc
Hmm, I have no idea what this means. Maybe some ghc compilation flag issue?

> pandoc-cli.x86_64: W: no-manual-page-for-binary pandoc
> pandoc-cli.x86_64: W: no-manual-page-for-binary pandoc-lua
> pandoc-cli.x86_64: W: no-documentation
... not relevant, as explained above.

+ package name is OK
+ license is acceptable for Fedora (GPL-2.0-or-later)
+ license is specified correctly (SPDX)
+ cabal-rpm-2.1.5 was used to generate a standard ghc spec file
+ builds and installs OK
+ upgrades from old pandoc also work fine
+ /usr/bin/pandoc seems to work exactly as before

Old-style %changelog is used, bleh :(

Package is APPROVED.

Awesome, thank you very much, Zbigniew!

I think I can move forward with fixing the CVE and version lag now finally easily, yay

(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> rpmlint:
> > pandoc-cli.x86_64: W: position-independent-executable-suggested /usr/bin/pandoc
> Hmm, I have no idea what this means. Maybe some ghc compilation flag issue?

I think this might be the static Haskell library linking but I am not certain.

> Old-style %changelog is used, bleh :(

Do you mean the date format? Maybe you prefer to include the timestamp?
I mostly use rpm-spec-mode in Emacs.
(I don't mind - though I try to use datestamps that apply for UTC:
personally I sometimes find timestamps a bit too fine grained here:
I don't always submit/push changes immediately anyway, sometimes hours or days later.)

But I could update cabal-rpm to generate the newer format I suppose.

Thank you again for reviewing, Zbigniew

The Pagure repository was created at https://src.fedoraproject.org/rpms/pandoc-cli

> Do you mean the date format?

I'd just use %autorelease and %autochangelog.
(But this is just a suggestion. The smiley was supposed to indicate that.)

(In reply to Zbigniew Jędrzejewski-Szmek from comment #8)
> > Do you mean the date format?
> 
> I'd just use %autorelease and %autochangelog.
> (But this is just a suggestion. The smiley was supposed to indicate that.)

Ah okay I see right - I can do that but only after getting rid of all the subpackages ;o)

This is now built for Rawhide - any testing would be welcome, since it is quite a large packaging change.

I will send an announcement to devel list too.

Also backported to F39+