Bug 2266245
| Summary: | Review Request: rust-olpc-cjson - Serde_json Formatter to serialize as OLPC-style canonical JSON | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Mellado <dmellado> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| URL: | https://crates.io/crates/olpc-cjson | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-03-07 15:50:21 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Daniel Mellado
2024-02-27 10:18:30 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=114121583 Copr build: https://copr.fedorainfracloud.org/coprs/build/7064297 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266245-rust-olpc-cjson/fedora-rawhide-x86_64/07064297-rust-olpc-cjson/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > # FIXME: paste output of %%cargo_license_summary here
> License: # FIXME
These are not generated for fun, they must be addressed :)
Also, if you don't need the olpc-cjson binary at all, dropping it would make the package even simpler.
Patching Cargo.toml with "rust2rpm -p" and adding the line "autobins = false" under "repository = ..." should do it.
Thanks! Updated the specfile and srpm Spec URL: https://dmellado.fedorapeople.org/rust-olpc-cjson/rust-olpc-cjson.spec SRPM URL: https://dmellado.fedorapeople.org/rust-olpc-cjson/rust-olpc-cjson-0.1.3-1.fc39.src.rpm Description: Serde_json Formatter to serialize as OLPC-style canonical JSON. Fedora Account System Username: dmellado Created attachment 2019418 [details]
The .spec file difference from Copr build 7064297 to 7091869
Copr build: https://copr.fedorainfracloud.org/coprs/build/7091869 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266245-rust-olpc-cjson/fedora-rawhide-x86_64/07091869-rust-olpc-cjson/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Looks good to me now, thank you! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-olpc-cjson FEDORA-2024-e1e93b3c34 (rust-olpc-cjson-0.1.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e1e93b3c34 FEDORA-2024-e1e93b3c34 (rust-olpc-cjson-0.1.3-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |