Bug 2266273

Summary:	Review Request: rust-spectral - Fluent test assertions
Product:	[Fedora] Fedora	Reporter:	Daniel Mellado <dmellado>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review?
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/spectral
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-03-06 16:17:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Daniel Mellado 2024-02-27 12:08:40 UTC

Spec URL: https://dmellado.fedorapeople.org/rust-spectral/rust-spectral.spec
SRPM URL: https://dmellado.fedorapeople.org/rust-spectral/rust-spectral-0.6.0-1.fc39.src.rpm

Description:
Fluent test assertions.

Fedora Account System Username: dmellado

Comment 1 Daniel Mellado 2024-02-27 12:08:43 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=114126869

Comment 2 Fedora Review Service 2024-02-27 12:14:26 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7064471
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266273-rust-spectral/fedora-rawhide-x86_64/07064471-rust-spectral/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2024-02-29 15:12:47 UTC

This package is *ancient* ... are you sure you need this? Or would it be possible to replace it with something that is not dusty and old?

There's two minor issues that would need fixing:

- If you disable tests, please add a short comment in the line preceding "%bcond_with check" that explains the reason.
- The downstream patch to bump the "num" dependency from 0.1 to 0.4 needs a short comment too.

Comment 4 Daniel Mellado 2024-03-06 16:17:29 UTC

Closing this as spectral is now considered outdated