Bug 2266450

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7066109
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266450-rust-fts-sys/fedora-rawhide-x86_64/07066109-rust-fts-sys/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Package looks fine, just one weird thing I noticed in Cargo.toml:

> links = "c"

This looks wrong. I don't think this crate should claim that it has exclusive rights to link against "c". Or is it a typo and it should be "libc"? Even then, it would be wrong, I think.

PS: You might also want to add a dependency on glibc-devel - looks like <fts.h> that is imported by this package is from glibc.

huh, yes. It sounds like it should be libc which explains the dependency on glibc-devel anyway? I wonder how it got transitively pulled in.

From what I can tell:

- remove `links = "c"` from Cargo.toml
- add glibc-devel as build dependency and dependency for the -devel package

from the cargo docs:

> Primarily, Cargo requires that there is at most one package per links value.
> In other words, it is forbidden to have two packages link to the same native library.

ref. https://doc.rust-lang.org/cargo/reference/build-scripts.html#the-links-manifest-key

I'm pretty sure this means that `links = "c"` should be removed from upstream as well, and that this is only working by accident, because not even the "libc" crate (*the* libc bindings) claims to link with libc: https://github.com/rust-lang/libc/blob/main/Cargo.toml

Are you still interested in this package?

Yep, need it for uu_chcon. Will get back to it once we rebase to the version of uu we need for the current version of nushell

update, still working on this - needed to enable the selinux feature of coreutils

Updated; tested and building rust-uu_chcon against it works

Spec URL: https://salimma.fedorapeople.org/specs/rust-fts-sys.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-fts-sys-0.2.9-1.fc40.src.rpm

❯ cat rust2rpm.toml
[package]
cargo-toml-patch-comments = [
  "drop links = \"c\"",
]

[requires]
build = ["glibc-devel"]
lib = ["glibc-devel"]

Created attachment 2045035 [details]
The .spec file difference from Copr build 7066109 to 7953294

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7953294
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266450-rust-fts-sys/fedora-rawhide-x86_64/07953294-rust-fts-sys/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thanks - looks good to me!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-fts-sys

Thank you!

FEDORA-2024-42d3ffde85 (rust-fts-sys-0.2.9-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-42d3ffde85

FEDORA-2024-42d3ffde85 (rust-fts-sys-0.2.9-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-ec89486d77 (rust-fts-sys-0.2.9-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ec89486d77

FEDORA-2024-576ffacbc8 (rust-fts-sys-0.2.9-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-576ffacbc8

FEDORA-EPEL-2024-708f932e41 (rust-fts-sys-0.2.9-1.el9) has been submitted as an update to Fedora EPEL 9.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-708f932e41

FEDORA-2024-91bdb7967a (rust-fts-sys-0.2.9-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-91bdb7967a

FEDORA-EPEL-2024-708f932e41 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-708f932e41

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-ec89486d77 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ec89486d77 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ec89486d77

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-576ffacbc8 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-576ffacbc8 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-576ffacbc8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-91bdb7967a has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-91bdb7967a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-91bdb7967a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2024-ec89486d77 (rust-fts-sys-0.2.9-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-EPEL-2024-708f932e41 (rust-fts-sys-0.2.9-1.el9) has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-576ffacbc8 (rust-fts-sys-0.2.9-1.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2024-91bdb7967a (rust-fts-sys-0.2.9-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.