Bug 2266553

Summary:	hyperhdr-common-0:20.0.0.0-0.5.fc41 breaks build root
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	hyperhdr	Assignee:	Vasiliy Glazov <vascom2>
Status:	CLOSED RAWHIDE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	awilliam, jwakely, petersen, vascom2
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-02-28 09:35:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2024-02-28 08:38:25 UTC

hyperhdr-common-0:20.0.0.0-0.5.fc41.x86_64 incorrectly RPM-provides "libcap.so.2()(64bit)", breaking the system. See <https://pagure.io/releng/issue/11986>. Th That library belongs to libcap:

# dnf5 --disable-repo=rawhide --enable-repo=f41-build repoquery --whatprovides 'libcap.so.2()(64bit)'
Updating and loading repositories:
Repositories loaded.
hyperhdr-common-0:20.0.0.0-0.5.fc41.x86_64
libcap-0:2.69-3.fc40.x86_64

# dnf5 --disable-repo=rawhide --enable-repo=f41-build repoquery --list hyperhdr-common |grep cap
/usr/share/hyperhdr/lib/libcap.so.2
/usr/share/hyperhdr/lib/libcap.so.2.69

Please stop providing that library. Preferably stop bundling that library.

Comment 1 Petr Pisar 2024-02-28 08:44:21 UTC

Moreover architecture-specific files (libraries) are forbidden to be installed into /usr/share

Comment 2 Adam Williamson 2024-02-28 09:05:50 UTC

It's not just libcap, it's claiming to provide *hundreds* of libraries, all the way from libEGL.so.1()(64bit) to libzstd.so.1()(64bit). See the list at https://koji.fedoraproject.org/koji/rpminfo?rpmID=37902254 . Clearly something went seriously wrong with this build.

Comment 3 Adam Williamson 2024-02-28 09:11:40 UTC

It looks like the bump dropped a weird giant patch just called "fix.patch", which did a lot of nonsensical messing around with whitespace but *also* seems to have been preventing the hyperhdr install scripts from copying a whole bunch of system libraries to /usr/share/hyperhdr/lib . So now the patch is gone, the install process does copy all those libraries to /usr/share/hyperhdr/lib , and the package includes them, so the auto-provides helper adds provides for them.

Comment 4 Jens Petersen 2024-02-28 09:14:48 UTC

Per https://pagure.io/releng/issue/11986 the build was untagged from f41 rawhide

Comment 5 Vasiliy Glazov 2024-02-28 09:16:01 UTC

I am reverted change
https://koji.fedoraproject.org/koji/taskinfo?taskID=114174695

Comment 6 Adam Williamson 2024-02-28 09:25:45 UTC

thanks for that. to get back to the beta5 build you'll probably need to rediff fix.patch , dropping the bits that are useless whitespace changes but keeping the bits that stop it doing bad things like bundling hundreds of system libraries :)

Comment 7 Vasiliy Glazov 2024-02-28 09:34:43 UTC

Yes. My mistake.

Comment 8 Jonathan Wakely 2024-03-06 15:33:30 UTC

Why does "fix.patch" have such an unhelpful name? Why does it have no explanation of what it's for, either in the spec file or the git logs?

Could that be improved please?